Skip to content

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Apr 22, 2025

https://mikaygo.itch.io/ddm/devlog/924616/410

  • Unsure if this is issue-free, since the devlog notes that the game may now download smaller updates automatically, and I haven't been able to test if/how that works

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Apr 26, 2025

Builds, but currently doesn't work properly: New version introduced some path sanity checking, which fails on our patch to change the images cache path to $HOME/.cache/ddm. Will need an update on the patch.

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 1, 2025

Patch updated. Still unsure about the supposed update mechanism, but we'll get there when it hits us ig.

@OPNA2608 OPNA2608 marked this pull request as ready for review May 1, 2025 14:25
@OPNA2608 OPNA2608 merged commit 3175699 into NixOS:master May 7, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant