protonvpn-gui: 4.9.5 -> 4.9.6

[Steinhagen]

Update the package to the latest versions and remove the broken tag.

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Steinhagen]

.#python313Packages.proton-vpn-network-manager is still failing for the Python 3.13 version. It works as expected for the 3.12 version though. The update will be marked as draft until this issue is resolved.

[Steinhagen]

The python mismatch is problematic, but doesn't block the final ProtonVPN build application. Since to my knowledge, there isn't any other application that depends on this library, I think we can remove the broken tag from it and track this issue separately in: #401088

[pbsds]

# https://github.com/NixOS/nixpkgs/issues/401088
# ModuleNotFoundError: No module named 'proton.vpn.local_agent'
broken = pythonAtLeast "3.13";

[dotlambda]

Please just fix proton-vpn-local-agent using

override { python3 = python; }

[dotlambda]

Actually, doesn't this PR already fix that issue?

[pbsds]

now it does yes, and that was the initial proposed fix in #400949 (comment)

[pbsds]

A working fix is (proton-vpn-local-agent.override { python3 = python; }), but tbh proton-vpn-local-agent should be moved to pkgs/development/python-modules/

[pbsds]

I pushed the fix, please test

[Steinhagen]

Everything works as expected right now after the migration to of the local-agent package to python.

[dotlambda]

Does proton-vpn-local-agent have an executable? If so please add mainProgram.

[Steinhagen]

Does proton-vpn-local-agent have an executable? If so please add mainProgram.

To my knowledge, it doesn't. The main repository just compiles the library in rust and documents how to add it to your python site-packages.

[dotlambda]

Does proton-vpn-local-agent have an executable? If so please add mainProgram.

To my knowledge, it doesn't. The main repository just compiles the library in rust and documents how to add it to your python site-packages.

Then why was it ever a top-level attribute?

[pbsds]

Then why was it ever a top-level attribute?

I asked myself the very same question

[Steinhagen]

Does proton-vpn-local-agent have an executable? If so please add mainProgram.

To my knowledge, it doesn't. The main repository just compiles the library in rust and documents how to add it to your python site-packages.

Then why was it ever a top-level attribute?

The fault for that is on me. I wasn't aware at the time of packaging that this will only be a python library. Sorry about this.

[pbsds]

No worries 👍, we can't expect all contributors to be aware of all conventions! 😅
What surprises rather me is that this initially managed to slip through review

[Atemu]

Diff LGTM and it works on my machine.