Skip to content

nixos/unifi: refactor test and package + update to 9.1.119 #400950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kranzes merged 2 commits into from
Apr 25, 2025
Merged

nixos/unifi: refactor test and package + update to 9.1.119 #400950

Kranzes merged 2 commits into from
Apr 25, 2025

Conversation

@Kranzes
Copy link
Member

@Kranzes Kranzes commented Apr 22, 2025 •
edited
Loading

  • use autoPatchElf
  • correct supported platforms
  • use finalAttrs and stdenvNoCC
  • use runTest
  • attest the status of the service
  • update to 9.1.119

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Apr 22, 2025
@Kranzes Kranzes requested review from Patryk27 and zhaofengli April 22, 2025 21:51
@Kranzes
nixos/unifi: refactor test and package
65506eb 
- use autoPatchElf
- correct supported platforms
- use finalAttrs and stdenvNoCC
- use runTest
- attest the status of the service
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 22, 2025
@nix-owners nix-owners bot requested a review from globin April 22, 2025 21:59
@Patryk27
Copy link
Member

Patryk27 commented Apr 24, 2025

Hi, just a quick status - I'll take a look at the changes tomorrow 🙂

@Kranzes Kranzes changed the title nixos/unifi: refactor test and package nixos/unifi: refactor test and package + update to 9.1.119 Apr 24, 2025
@Patryk27 Patryk27 mentioned this pull request Apr 25, 2025
Closed
Patryk27
Patryk27 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@Patryk27 Patryk27 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass (though mongodb is... a beast to compile, to say the least), code seems neat (nice eye with autoPatchelf), all good to me! 🚀

@Kranzes Kranzes merged commit d2c1380 into NixOS:master Apr 25, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaofengli zhaofengli Awaiting requested review from zhaofengli

@globin globin Awaiting requested review from globin

1 more reviewer

@Patryk27 Patryk27 Patryk27 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kranzes @Patryk27