snander: init at 1.7.8

[bmwagner18]

https://github.com/Droid-MAX/SNANDer

C program for reading and flashing flash chips using CH341A programmers.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[illdefined]

I left a few recommendations for changes.

You could also consider providing an update script. Something like passthru.updateScript = nix-update-script { extraArgs = [ "--version=branch" ]; }; might just work, but I remember that nix-update had difficulties with unstable Git versions in the past.

[bmwagner18]

I left a few recommendations for changes.

You could also consider providing an update script. Something like passthru.updateScript = nix-update-script { extraArgs = [ "--version=branch" ]; }; might just work, but I remember that nix-update had difficulties with unstable Git versions in the past.

I added the update script. Is there a way to test it?

[0xda157]

I added the update script. Is there a way to test it?

you can run nix-shell -p nix-update --run "nix-update snander", which is what nix-update-script does automatically.

[bmwagner18]

I added the update script. Is there a way to test it?

you can run nix-shell -p nix-update --run "nix-update snander", which is what nix-update-script does automatically.

The author of this project uses v.<major>.<minor>.<patch> for their versions and this seems to break nix-update because it finds version .1.7.8. I tried to fix it with the --version-regex argument in nix-update but to no avail.

passthru.updateScript = nix-update-script { extraArgs = [ "--version-regex='v.(.*)'" ]; };

[0xda157]

The author of this project uses v.<major>.<minor>.<patch> for their versions and this seems to break nix-update because it finds version .1.7.8. I tried to fix it with the --version-regex argument in nix-update but to no avail.

passthru.updateScript = nix-update-script { extraArgs = [ "--version-regex='v.(.*)'" ]; };

I believe you need to escape the ., like this: "--version-regex='v\.(.*)'"

[bmwagner18]

The author of this project uses v.<major>.<minor>.<patch> for their versions and this seems to break nix-update because it finds version .1.7.8. I tried to fix it with the --version-regex argument in nix-update but to no avail.
passthru.updateScript = nix-update-script { extraArgs = [ "--version-regex='v.(.*)'" ]; };

I believe you need to escape the ., like this: "--version-regex='v\.(.*)'"

Oh duh... I'm not super familiar with regex but obviously the '.' character is special in regex. I was able to get it to work and I've pushed an updated commit

[0xda157]

you should just have snander: init at 1.7.8 and snander: init at 1.7.8 as your only commits (an interactive rebase is probably the best way to get there)

[bmwagner18]

you should just have snander: init at 1.7.8 and snander: init at 1.7.8 as your only commits (an interactive rebase is probably the best way to get there)

Whew ok I think I got it. Thanks for your patience... This is one of my first times working on a repo that isn't just me.

[0xda157]

otherwise LGTM

[illdefined]

If you use double quotes, you’ll have to escape the backslash character with another one. As this quickly becomes unreadable, I suggest to use double single quotes instead for this kind of regex.

Suggested change

	"^v\.(\d+\.\d+\.\d+)$"
	''^v\.(\d+\.\d+\.\d+)$''

[bmwagner18]

I amended my personal fork's commit and force pushed it. The change is reflected in my personal repo, but the change didn't seem to propagate to this PR. Any suggestions?

[illdefined]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401003

---

x86_64-linux

✅ 1 package built:

• snander

---

aarch64-linux

✅ 1 package built:

• snander