rt-tests: add cross compilation support #401020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
the
6.topic: cross-compilation
3 tasks
NixOSInfra
added
the
12.first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
illdefined
suggested changes
Apr 23, 2025
Contributor
illdefined
left a comment
illdefined
left a comment
There was a problem hiding this comment.
I don’t think it makes sense to include gcc as an explicit dependency as the C compiler (which might not be GCC but Clang for example) is already provided through stdenv.
Contributor
|
I am currently testing cross‐compilation for Aarch64 and RISC-V. I’ll post the results and approve this PR if successful. |
Contributor
|
Contributor
|
This appears to have resolved the cross‐compilation issue. Thanks for your contribution, @enkerewpo. If you have other packages with cross‐compilation problems, feel free to involve me as a reviewer. |
illdefined
approved these changes
Apr 24, 2025
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rt-tests: add cross compilation support
issue: #401023
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.