Skip to content

Conversation

@jaredmontoya
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2025
@nix-owners nix-owners bot requested a review from CardboardTurkey April 23, 2025 08:10
@illdefined
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401058


x86_64-linux

✅ 1 package built:
  • nu_scripts

aarch64-linux

✅ 1 package built:
  • nu_scripts

Copy link
Contributor

@illdefined illdefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The licence should be set more specifically to lib.licenses.mit instead of lib.licenses.free.

The package outputs look good, although I would like to note that the repository’s README and LICENSE files are included in the script directory. They could be moved to share/doc for example, for cleanliness, but this is not important in my opinion.

The package update itself is fine, but I’d recommend to drop rec or use finalAttrs, set the source repo name literally, and correct meta.license in additional commits.

@jaredmontoya jaredmontoya requested a review from illdefined April 23, 2025 15:18
@illdefined
Copy link
Contributor

Thanks for the update. It does unfortunately omit correction of the licence information.

The repository contains a standard MIT licence while the meta.license attribute is specified as lib.licenses.free. This should be changed to lib.licenses.mit.

@jaredmontoya
Copy link
Contributor Author

fixed

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 23, 2025
@NickCao NickCao merged commit e9af77c into NixOS:master Apr 23, 2025
25 of 28 checks passed
@jaredmontoya jaredmontoya deleted the update-nu_scripts branch April 24, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants