python3Packages.pymonocypher: init at 4.0.2.5 #401063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
renesat
reviewed
Apr 23, 2025
Comment on lines
+31
to
+35
Contributor
There was a problem hiding this comment.
You need to add unittestCheckHook for tests on checkPhase:
Suggested change
| doCheck = true; | |
| pythonImportsCheck = [ "monocypher" ]; | |
| doCheck = true; | |
| pythonImportsCheck = [ "monocypher" ]; | |
| nativeCheckInputs = [ | |
| unittestCheckHook | |
| ]; |
Author
There was a problem hiding this comment.
Thank you, @renesat! Good now? Build log shows
python3.12-pymonocypher> Executing unittestCheckPhase
python3.12-pymonocypher> unittest flags: ''
python3.12-pymonocypher> ..../nix/store/fqm9bqqlmaqqr02qbalm1bazp810qfiw-python3-3.12.9/lib/python3.12/unittest/case.py:589: DeprecationWarning: Provide the full 64-byte key from generate_signing_key_pair()
python3.12-pymonocypher> if method() is not None:
python3.12-pymonocypher> ..........
python3.12-pymonocypher> ----------------------------------------------------------------------
python3.12-pymonocypher> Ran 14 tests in 0.096s
python3.12-pymonocypher>
python3.12-pymonocypher> OK
python3.12-pymonocypher> Finished executing unittestCheckPhase
13 tasks
nixpkgs-ci
bot
added
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
12.first-time contribution
nixpkgs-ci
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python bindings for Monocypher crypto library
https://github.com/jetperch/pymonocypher
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.