Skip to content

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 23, 2025

Things done

  • python312Packages.kfactory: 0.21.7 -> 1.4.4
  • python312Packages.gdsfactory: 8.18.1 -> 9.5.1

cc @fedeinthemix

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2025
@nix-owners nix-owners bot requested a review from fedeinthemix April 23, 2025 09:22
@GaetanLepage GaetanLepage requested a review from kirillrdy April 23, 2025 09:25
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401075


x86_64-linux

✅ 8 packages built:
  • python312Packages.gdsfactory
  • python312Packages.gdsfactory.dist
  • python312Packages.kfactory
  • python312Packages.kfactory.dist
  • python313Packages.gdsfactory
  • python313Packages.gdsfactory.dist
  • python313Packages.kfactory
  • python313Packages.kfactory.dist

aarch64-linux

✅ 8 packages built:
  • python312Packages.gdsfactory
  • python312Packages.gdsfactory.dist
  • python312Packages.kfactory
  • python312Packages.kfactory.dist
  • python313Packages.gdsfactory
  • python313Packages.gdsfactory.dist
  • python313Packages.kfactory
  • python313Packages.kfactory.dist

@GaetanLepage GaetanLepage merged commit 6824783 into NixOS:master Apr 23, 2025
55 of 59 checks passed
@GaetanLepage GaetanLepage deleted the gdsfactory branch April 23, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants