Skip to content

openimageio: 2.5.16.0 -> 3.0.5.0 #401089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 9 commits into from
Apr 25, 2025
Merged

openimageio: 2.5.16.0 -> 3.0.5.0 #401089

SuperSandro2000 merged 9 commits into from
Apr 25, 2025

Conversation

@yzx9
Copy link
Contributor

@yzx9 yzx9 commented Apr 23, 2025 •
edited
Loading

Openimageio v3 was released in Nov 9, 2024. This PR bumps openimageio from 2.5.16.0 to 3.0.5.0.

However, v3 introduces many breaking changes that some consumers are not yet ready for, and updating them would require complex changes. To address this, we’ve introduced openimageio_2 at version 2.5.17.0. This legacy package is expected to be removed once it is no longer used in nixpkgs.

Also, openimageio has been relicensed under Apache-2.0

close #363100

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 23, 2025
@nix-owners nix-owners bot requested review from Hodapp87, ShaddyDC and gador April 23, 2025 10:16
@yzx9 yzx9 force-pushed the openimageio-3 branch 3 times, most recently from bd11bdc to edbd65f Compare April 23, 2025 11:36
@nix-owners nix-owners bot requested review from TomaSajt, amarshall and veprbl April 23, 2025 11:45
amarshall
amarshall reviewed Apr 23, 2025
View reviewed changes
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Comments based on diffs only, have not yet done build testing)

I have a mild preference for the commits to be something like:

  • openimageio: move to by-name
  • openimageio: 2.5.16.0 -> 2.5.17.0, fix incorrect license
  • openimageio: 2.5.17.0 -> 3.0.5.0; openimageio_2: init at 2.5.17.0

With all the necessary changes to dependents in that last one. This is to make bisecting easier—with the current commits in the PR the majority of commits have various drvs (presumably) failing to build.

@yzx9
openimageio: 2.5.16.0 -> 2.5.17.0, fix incorrect license
bfb90a9 
- v2.5.17.0 was released on Nov 1, 2024, includes bug fixes
- openimageio relicense their code under Apache 2.0
  AcademySoftwareFoundation/OpenImageIO#3905
- remove unnecessary patch
- remove `rec` and `with lib;`
@yzx9
Copy link
Contributor Author

yzx9 commented Apr 23, 2025 •
edited
Loading

@amarshall Thanks for your review! Bisecting makes sense to ensure that each commit builds successfully — I've updated the commits accordingly.

There are still a few build failures that I'm working to address. Also, it looks like gpupad has been broken for a while. (#401129)

@yzx9
Copy link
Contributor Author

yzx9 commented Apr 23, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401089

x86_64-linux

❌ 1 package failed to build:
  • gpupad
✅ 22 packages built:
  • blender
  • blender-hip
  • blendfarm
  • embree
  • embree2
  • materialx (python312Packages.materialx)
  • meshlab
  • meshlab-unstable
  • openimageio
  • openimageio.bin
  • openimageio.dev
  • openimageio.doc
  • openimageio_2
  • openimageio_2.bin
  • openimageio_2.dev
  • openimageio_2.doc
  • openusd
  • osl
  • python312Packages.openusd
  • python312Packages.pymeshlab (python313Packages.pymeshlab)
  • python313Packages.materialx
  • python313Packages.openusd

aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • blender
✅ 15 packages built:
  • embree
  • materialx (python312Packages.materialx)
  • openimageio
  • openimageio.bin
  • openimageio.dev
  • openimageio.doc
  • openimageio_2
  • openimageio_2.bin
  • openimageio_2.dev
  • openimageio_2.doc
  • openusd
  • osl
  • python312Packages.openusd
  • python313Packages.materialx
  • python313Packages.openusd

gpupad has been broken for a while (#401129), should not blocked this PR.

@yzx9 yzx9 requested a review from amarshall April 23, 2025 15:11
SuperSandro2000
SuperSandro2000 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gador
Copy link
Member

gador commented Apr 24, 2025

The tag seems to have changed

source> trying https://github.com/AcademySoftwareFoundation/OpenImageIO/archive/refs/tags/v3.0.5.0.tar.gz
source>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
source>                                  Dload  Upload   Total   Spent    Left  Speed
source>   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
source> 100 50.2M    0 50.2M    0     0  5084k      0 --:--:--  0:00:10 --:--:-- 5319k
source> unpacking source archive /private/tmp/nix-build-source.drv-0/download.tar.gz
error: hash mismatch in fixed-output derivation '/nix/store/r0mv9p5ldh5g121qpnq6chlqz8n0lvav-source.drv':
         specified: sha256-d5LqRcqWj6E9jJYY/Pa5e7/MeuQGMjUo/hMCYRKsKeU=
            got:    sha256-CG2tb6jf7xmQnrLaTqEFKG3g4nkEwZoI44bXxdCRmrM=

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 24, 2025
yzx9 added 7 commits April 25, 2025 15:33
@yzx9
openimageio: 2.5.17.0 -> 3.0.5.0; openimageio_2: init at 2.5.17.0
9e60f37 
Openimageio v3 was released in Nov 9, 2024. However, v3 introduces many
breaking changes that some consumers are not yet ready for, and
updating them would require complex changes. To address this, we’ve
introduced openimageio_2 at version 2.5.17.0. This legacy package is
expected to be removed once it is no longer used in nixpkgs.
@yzx9
embree{,2}: use openimageio_2
45d72c1
@yzx9
osl: use openimageio_2
9064f8b
@yzx9
gpupad: use openimageio_2
6fb1418
@yzx9
python3Packages.materialx: use openimageio_2
b8aff03
@yzx9
python3Packages.openusd: use openimageio_2
b8f327f
@yzx9
blender: use openimageio_2
a7d096c
@yzx9
Copy link
Contributor Author

yzx9 commented Apr 25, 2025

@gador Thanks for your review! The tag itself wasn’t changed. However, a subtle mistake was made when I changed
openimageio.overrideAttrs(finalAttrs: prevAttrs: { ... }) to openimageio.overrideAttrs (finalAttrs: { ... }). In this case, finalAttrs is actually bound to prevAttrs, which caused us to reference the wrong version. To avoid this, I’ve switched to using the let ... in pattern.

@gador
Copy link
Member

gador commented Apr 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401089

aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • blender
✅ 15 packages built:
  • embree
  • materialx (python312Packages.materialx)
  • openimageio
  • openimageio.bin
  • openimageio.dev
  • openimageio.doc
  • openimageio_2
  • openimageio_2.bin
  • openimageio_2.dev
  • openimageio_2.doc
  • openusd
  • osl
  • python312Packages.openusd
  • python313Packages.materialx
  • python313Packages.openusd

@SuperSandro2000 SuperSandro2000 merged commit fb8af74 into NixOS:master Apr 25, 2025
24 of 27 checks passed
@yzx9 yzx9 deleted the openimageio-3 branch April 25, 2025 13:39
@yzx9 yzx9 mentioned this pull request Apr 29, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ShaddyDC ShaddyDC Awaiting requested review from ShaddyDC

@gador gador Awaiting requested review from gador

@Hodapp87 Hodapp87 Awaiting requested review from Hodapp87

@TomaSajt TomaSajt Awaiting requested review from TomaSajt

@veprbl veprbl Awaiting requested review from veprbl

@amarshall amarshall Awaiting requested review from amarshall

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yzx9 @gador @amarshall @SuperSandro2000 @wegank