Skip to content

television: 0.11.7 -> 0.11.9 #401095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
getchoo merged 1 commit into from
Apr 25, 2025
Merged

television: 0.11.7 -> 0.11.9 #401095

getchoo merged 1 commit into from
Apr 25, 2025

Conversation

@louis-thevenet
Copy link
Member

@louis-thevenet louis-thevenet commented Apr 23, 2025

Diff: alexpasmantier/television@0.11.7...0.11.9
Changelog: https://github.com/alexpasmantier/television/releases/tag/0.11.9

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2025
@nix-owners nix-owners bot requested a review from getchoo April 23, 2025 10:46
matteo-pacini
matteo-pacini approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Looking good on Darwin

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401095

x86_64-darwin

✅ 1 package built:
  • television

aarch64-darwin

✅ 1 package built:
  • television

@matteo-pacini matteo-pacini added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 23, 2025
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 23, 2025
@louis-thevenet louis-thevenet added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Apr 23, 2025
@getchoo getchoo added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Apr 25, 2025
@getchoo
Copy link
Member

getchoo commented Apr 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401095

x86_64-linux

✅ 1 package built:
  • television

@getchoo getchoo merged commit 0f8463e into NixOS:master Apr 25, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matteo-pacini matteo-pacini matteo-pacini approved these changes

@getchoo getchoo getchoo approved these changes

+1 more reviewer

@ddogfoodd ddogfoodd ddogfoodd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@louis-thevenet @getchoo @matteo-pacini @ddogfoodd @wegank