-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
libblake3: 1.8.0 -> 1.8.2 (fixed nix build) #401156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nix (and therefore the nixpkgs manual) does build for me again, so LGTM! |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-401156-to-release-24.11 origin/release-24.11
cd .worktree/backport-401156-to-release-24.11
git switch --create backport-401156-to-release-24.11
git cherry-pick -x e4c1dd71baf134ab416015ff675d55a03c9fdc80 |
|
I can't check it ))) |
|
it is fixed, I can confirm |
|
I disabled |
|
@silvanshade Can you try |
|
uxlfoundation/oneTBB#1696 Also would be good to get this in. |
@Ericson2314 I re-enabled TBB because I was under the impression that the only reason the MinGW builds broke was because of the compiler check (which was removed in BLAKE3-team/BLAKE3#468). Is that not the case?
I will try. Can you also verify if you get a chance, just to have an extra point of reference?
Should I make a new PR adding this to the local patches for the time being? |
|
@silvanshade Good point, yes 1.8.2 makes it well primed to try this again! Sorry about that.
I guess 1.8.2 does have all your recent packages too. I can try also. I made some other windows fixes on nixpkgs
Sure, or if FreeBSD is not building, I think you can disable building the oneTBB tests on that platform too and that will also suffice. |
|
Also btw @silvanshade I just tried messaging you on Matrix, if you use that :) |
|
Just to give an update for everyone, I've verified the MinGW builds are working with this PR. The FreeBSD builds required an additional change which is now submitted at #401250 |
This PR updates
libblake3to version1.8.2.This is the second attempt and fixes #401117.
The change that needed to be made was adding
tbbto thepropagatedBuildInputs.@spiage @Floki @imincik Can you please verify this is working? I did test the previous PR locally but somehow my configuration didn't reveal the issue, although I was eventually able to reproduce and hopefully fix.
Related:
Things done