Skip to content

python312Packages.nanobind: cleanup #401189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drupol merged 1 commit into from
Apr 23, 2025
Merged

python312Packages.nanobind: cleanup #401189

drupol merged 1 commit into from
Apr 23, 2025

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 23, 2025 •
edited
Loading

Things done

cc @phiadaarr

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 23, 2025
@GaetanLepage GaetanLepage requested a review from phiadaarr April 23, 2025 18:12
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 23, 2025
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Apr 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401189 --package python312Packages.nanobind --package python312Packages.nanobind.tests --package python313Packages.nanobind --package python313Packages.nanobind.tests

x86_64-linux

✅ 6 packages built:
  • python312Packages.nanobind
  • python312Packages.nanobind.dist (python312Packages.nanobind.dist.dist)
  • python312Packages.nanobind.tests.pytest
  • python312Packages.nanobind.tests.pytest.dist (python312Packages.nanobind.tests.pytest.dist.dist)
  • python313Packages.nanobind
  • python313Packages.nanobind.dist (python313Packages.nanobind.dist.dist)

aarch64-linux

✅ 6 packages built:
  • python312Packages.nanobind
  • python312Packages.nanobind.dist (python312Packages.nanobind.dist.dist)
  • python312Packages.nanobind.tests.pytest
  • python312Packages.nanobind.tests.pytest.dist (python312Packages.nanobind.tests.pytest.dist.dist)
  • python313Packages.nanobind
  • python313Packages.nanobind.dist (python313Packages.nanobind.dist.dist)

x86_64-darwin

✅ 8 packages built:
  • python312Packages.nanobind
  • python312Packages.nanobind.dist (python312Packages.nanobind.dist.dist)
  • python312Packages.nanobind.tests.pytest
  • python312Packages.nanobind.tests.pytest.dist (python312Packages.nanobind.tests.pytest.dist.dist)
  • python313Packages.nanobind
  • python313Packages.nanobind.dist (python313Packages.nanobind.dist.dist)
  • python313Packages.nanobind.tests.pytest
  • python313Packages.nanobind.tests.pytest.dist (python313Packages.nanobind.tests.pytest.dist.dist)

aarch64-darwin

✅ 6 packages built:
  • python312Packages.nanobind
  • python312Packages.nanobind.dist (python312Packages.nanobind.dist.dist)
  • python312Packages.nanobind.tests.pytest
  • python312Packages.nanobind.tests.pytest.dist (python312Packages.nanobind.tests.pytest.dist.dist)
  • python313Packages.nanobind
  • python313Packages.nanobind.dist (python313Packages.nanobind.dist.dist)

@drupol drupol merged commit 546a7aa into NixOS:master Apr 23, 2025
127 of 131 checks passed
@phiadaarr
Copy link
Contributor

phiadaarr commented Apr 23, 2025

Thank you for cleaning up :)

@GaetanLepage GaetanLepage deleted the nanobind branch April 23, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@phiadaarr phiadaarr Awaiting requested review from phiadaarr

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaetanLepage @phiadaarr @drupol