jujutsu: fix tests in darwin sandbox #401211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 1-10
nix-owners
bot
requested review from
0x4A6F,
bbigras,
emilazy and
thoughtpolice
thoughtpolice
approved these changes
Apr 23, 2025
wegank
added
12.approved-by: package-maintainer
winterqt
commented
Apr 24, 2025
|
|
||
| # taplo-cli (used in tests) always creates a reqwest client, which | ||
| # requires configd access on macOS. | ||
| sandboxProfile = '' |
Member
Author
There was a problem hiding this comment.
Overkill to gate this on finalAttrs.doCheck?
0x4A6F
approved these changes
Apr 24, 2025
wegank
added
12.approvals: 2
matteo-pacini
approved these changes
Apr 28, 2025
Contributor
matteo-pacini
left a comment
matteo-pacini
left a comment
There was a problem hiding this comment.
Tested on relaxed sandbox, LGTM
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 401211
x86_64-darwin
✅ 4 packages built:
- ctags-lsp
- jj-fzf
- jujutsu
- lazyjj
aarch64-darwin
✅ 4 packages built:
- ctags-lsp
- jj-fzf
- jujutsu
- lazyjj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.