Skip to content

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 23, 2025

Things done

Diff: google/flax@refs/tags/v0.10.5...refs/tags/v0.10.6
Changelog: https://github.com/google/flax/releases/tag/v0.10.6

cc @ndl

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 23, 2025
@nix-owners nix-owners bot requested a review from ndl April 23, 2025 20:38
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401226


x86_64-linux

⏩ 6 packages marked as broken and skipped:
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
  • python312Packages.treex
  • python312Packages.treex.dist
✅ 46 packages built:
  • minari (python312Packages.minari)
  • minari.dist (python312Packages.minari.dist)
  • python312Packages.ale-py
  • python312Packages.ale-py.dist
  • python312Packages.arviz
  • python312Packages.arviz.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.brax
  • python312Packages.brax.dist
  • python312Packages.corner
  • python312Packages.corner.dist
  • python312Packages.dalle-mini
  • python312Packages.dalle-mini.dist
  • python312Packages.evosax
  • python312Packages.evosax.dist
  • python312Packages.flax
  • python312Packages.flax.dist
  • python312Packages.flaxlib
  • python312Packages.flaxlib.dist
  • python312Packages.flowjax
  • python312Packages.flowjax.dist
  • python312Packages.gymnasium
  • python312Packages.gymnasium.dist
  • python312Packages.numpyro
  • python312Packages.numpyro.dist
  • python312Packages.nutpie
  • python312Packages.nutpie.dist
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.skrl
  • python312Packages.skrl.dist
  • python312Packages.stable-baselines3
  • python312Packages.stable-baselines3.dist
  • python312Packages.tianshou
  • python312Packages.tianshou.dist
  • python312Packages.vqgan-jax
  • python312Packages.vqgan-jax.dist
  • python312Packages.waymax
  • python312Packages.waymax.dist
  • python313Packages.flaxlib
  • python313Packages.flaxlib.dist

aarch64-linux

⏩ 6 packages marked as broken and skipped:
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
  • python312Packages.treex
  • python312Packages.treex.dist
✅ 46 packages built:
  • minari (python312Packages.minari)
  • minari.dist (python312Packages.minari.dist)
  • python312Packages.ale-py
  • python312Packages.ale-py.dist
  • python312Packages.arviz
  • python312Packages.arviz.dist
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.brax
  • python312Packages.brax.dist
  • python312Packages.corner
  • python312Packages.corner.dist
  • python312Packages.dalle-mini
  • python312Packages.dalle-mini.dist
  • python312Packages.evosax
  • python312Packages.evosax.dist
  • python312Packages.flax
  • python312Packages.flax.dist
  • python312Packages.flaxlib
  • python312Packages.flaxlib.dist
  • python312Packages.flowjax
  • python312Packages.flowjax.dist
  • python312Packages.gymnasium
  • python312Packages.gymnasium.dist
  • python312Packages.numpyro
  • python312Packages.numpyro.dist
  • python312Packages.nutpie
  • python312Packages.nutpie.dist
  • python312Packages.pettingzoo
  • python312Packages.pettingzoo.dist
  • python312Packages.pymc
  • python312Packages.pymc.dist
  • python312Packages.shimmy
  • python312Packages.shimmy.dist
  • python312Packages.skrl
  • python312Packages.skrl.dist
  • python312Packages.stable-baselines3
  • python312Packages.stable-baselines3.dist
  • python312Packages.tianshou
  • python312Packages.tianshou.dist
  • python312Packages.vqgan-jax
  • python312Packages.vqgan-jax.dist
  • python312Packages.waymax
  • python312Packages.waymax.dist
  • python313Packages.flaxlib
  • python313Packages.flaxlib.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.flaxlib
  • python312Packages.flaxlib.dist
  • python313Packages.flaxlib
  • python313Packages.flaxlib.dist

aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.treex
  • python312Packages.treex.dist
✅ 22 packages built:
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.dalle-mini
  • python312Packages.dalle-mini.dist
  • python312Packages.evosax
  • python312Packages.evosax.dist
  • python312Packages.flax
  • python312Packages.flax.dist
  • python312Packages.flaxlib
  • python312Packages.flaxlib.dist
  • python312Packages.flowjax
  • python312Packages.flowjax.dist
  • python312Packages.numpyro
  • python312Packages.numpyro.dist
  • python312Packages.nutpie
  • python312Packages.nutpie.dist
  • python312Packages.vqgan-jax
  • python312Packages.vqgan-jax.dist
  • python312Packages.waymax
  • python312Packages.waymax.dist
  • python313Packages.flaxlib
  • python313Packages.flaxlib.dist

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 24, 2025
@GaetanLepage GaetanLepage requested review from kirillrdy and removed request for happysalada April 24, 2025 07:46
@phanirithvij
Copy link
Member

nixpkgs-reviewd workflow finished

Status and logs: https://github.com/phanirithvij/nixpkgs-reviewd/actions/runs/14634119721

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401226


x86_64-darwin

✅ 4 packages built:
  • python312Packages.flaxlib
  • python312Packages.flaxlib.dist
  • python313Packages.flaxlib
  • python313Packages.flaxlib.dist

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401226


aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • python312Packages.elegy
  • python312Packages.elegy.dist
  • python312Packages.treex
  • python312Packages.treex.dist
❌ 2 packages failed to build:
  • python312Packages.nutpie
  • python312Packages.nutpie.dist
✅ 20 packages built:
  • python312Packages.bambi
  • python312Packages.bambi.dist
  • python312Packages.dalle-mini
  • python312Packages.dalle-mini.dist
  • python312Packages.evosax
  • python312Packages.evosax.dist
  • python312Packages.flax
  • python312Packages.flax.dist
  • python312Packages.flaxlib
  • python312Packages.flaxlib.dist
  • python312Packages.flowjax
  • python312Packages.flowjax.dist
  • python312Packages.numpyro
  • python312Packages.numpyro.dist
  • python312Packages.vqgan-jax
  • python312Packages.vqgan-jax.dist
  • python312Packages.waymax
  • python312Packages.waymax.dist
  • python313Packages.flaxlib
  • python313Packages.flaxlib.dist

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage GaetanLepage merged commit 1f0a12d into NixOS:master Apr 24, 2025
73 of 76 checks passed
@GaetanLepage GaetanLepage deleted the flax branch April 24, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants