eduvpn-client: symlink share folder into package root #401237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
NixOSInfra
added
the
12.first-time contribution
wegank
added
the
12.approvals: 1
Contributor
|
Is there any way I can make this easier upstream? |
Member
|
We could separate the resource files from the wheel and install them mentally or via a make target. Python itself does not really have an answer to this. |
Contributor
Manually? 😅 |
Contributor
@jwijenbergh you can create some kinda |
Member
oh, yeah, sorry. Smartphone auto correct 😅 |
Member
|
Lets improve that in another PR and fix the desktop file first. Any objections? |
benneti
approved these changes
Apr 25, 2025
jwijenbergh
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the .desktop files were not discovered by Plasma.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.