Skip to content

Conversation

@phaer
Copy link
Member

@phaer phaer commented Apr 23, 2025

follow-up on #382902. Building on linux is useful in order to be able to encrypt for age-plugin-se identities, while decrypting on the darwin machine with secure enclave.

Also removed the swift-crypto dependency from darwin builds as it should not be needed there according to upstream.

I tested basic operation: encrypting a secret for an age identity generated with age-plugin-se on darwin as well as decrypting that secret on (aarch64-)darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@phaer phaer force-pushed the age-plugin-se-linux branch from 5856187 to 2fc65f7 Compare April 23, 2025 23:51
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 23, 2025
@phaer phaer force-pushed the age-plugin-se-linux branch from 2fc65f7 to 9cb6932 Compare April 24, 2025 00:05
@phaer phaer marked this pull request as ready for review April 24, 2025 00:17
@phaer phaer requested a review from andre4ik3 April 24, 2025 00:19
@andre4ik3
Copy link
Contributor

andre4ik3 commented Apr 24, 2025

Hm, I was thinking to maybe do it with swiftpm2nix, but if this also works then it's cool.

I was able to build it on x86_64-linux and it works great, however I wasn't able to test it on aarch64-linux due to a seemingly unrelated XCTest build failure. Either way it works fine and works on Darwin as well (tested on aarch64-darwin).

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 24, 2025
@r-vdp r-vdp merged commit 25e832c into NixOS:master Apr 28, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants