concord: 2.3.0 -> 2.4.0

[r-ryantm]

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Cogmasters/concord/releases.

meta.description for concord is: Discord API wrapper library made in C

meta.homepage for concord is: https://cogmasters.github.io/concord/

meta.changelog for concord is: https://github.com/Cogmasters/concord/releases/tag/v2.4.0

Updates performed

• Version update

To inspect upstream changes

Impact

Checks done

---

• built on NixOS
• The tests defined in passthru.tests, if any, passed
• found 2.4.0 in filename of file in /nix/store/vwxjnzmlpgx6fs5qwjydzc61rlawjmnh-concord-2.4.0

---

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

concord

Instructions to test this update (click to expand)

---

Either download from the cache:

nix-store -r /nix/store/vwxjnzmlpgx6fs5qwjydzc61rlawjmnh-concord-2.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A concord https://github.com/r-ryantm/nixpkgs/archive/469f550b9cf5dd57a447284174b4831bde7da16d.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/469f550b9cf5dd57a447284174b4831bde7da16d#concord

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/vwxjnzmlpgx6fs5qwjydzc61rlawjmnh-concord-2.4.0
ls -la /nix/store/vwxjnzmlpgx6fs5qwjydzc61rlawjmnh-concord-2.4.0/bin

---

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

---

x86_64-linux

✅ 1 package built:

• concord

---

Maintainer pings

cc @Sigmanificient for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

---

Add a 👍 reaction to pull requests you find important.

[Sigmanificient]

There some improvements that could be included in here

[wolfgangwalther]

The darwin build failures seem to be regressions. Error is:

Undefined symbols for architecture x86_64:
  "_curl_easy_cleanup", referenced from:
      _ua_cleanup in user-agent.o
      __cws_cleanup in curl-websocket.o
  "_curl_easy_getinfo", referenced from:
      _discord_requestor_info_read in discord-rest_request.o
      _ua_info_extract in user-agent.o
      __ws_curl_tls_check in websockets.o
      _cws_send in curl-websocket.o
      _cws_ping in curl-websocket.o
      _cws_pong in curl-websocket.o
      _cws_close in curl-websocket.o
      ...
  "_curl_easy_init", referenced from:
      _ua_conn_start in user-agent.o
      _cws_new in curl-websocket.o
  "_curl_easy_pause", referenced from:
      __cws_send in curl-websocket.o
  "_curl_easy_perform", referenced from:
      _ua_conn_easy_perform in user-agent.o
      _ua_easy_run in user-agent.o
  "_curl_easy_setopt", referenced from:
      __discord_request_send in discord-rest_request.o
      _ua_conn_start in user-agent.o
      _ua_conn_setup in user-agent.o
      _ws_start in websockets.o
      _cws_close in curl-websocket.o
      _cws_new in curl-websocket.o
  "_curl_easy_strerror", referenced from:
      _discord_requestor_info_read in discord-rest_request.o
      __discord_request_to_multipart in discord-rest_request.o
      _ua_conn_setup in user-agent.o
      _ua_conn_easy_perform in user-agent.o
      _ua_easy_run in user-agent.o
      _ws_end in websockets.o
  "_curl_escape", referenced from:
      _discord_create_reaction in channel.o
      _discord_delete_own_reaction in channel.o
      _discord_delete_user_reaction in channel.o
      _discord_get_reactions in channel.o
      _discord_delete_all_reactions_for_emoji in channel.o
      _discord_search_guild_members in guild.o
  "_curl_free", referenced from:
      _discord_create_reaction in channel.o
      _discord_delete_own_reaction in channel.o
      _discord_delete_user_reaction in channel.o
      _discord_get_reactions in channel.o
      _discord_delete_all_reactions_for_emoji in channel.o
      _discord_search_guild_members in guild.o
      _ua_conn_add_header in user-agent.o
      ...
  "_curl_getdate", referenced from:
      _discord_ratelimiter_build in discord-rest_ratelimit.o
  "_curl_global_cleanup", referenced from:
      _ccord_global_init in concord-once.o
      _ccord_global_cleanup in concord-once.o
  "_curl_global_init", referenced from:
      _ccord_global_init in concord-once.o
  "_curl_mime_addpart", referenced from:
      __discord_request_to_multipart in discord-rest_request.o
  "_curl_mime_data", referenced from:
      __discord_request_to_multipart in discord-rest_request.o
  "_curl_mime_filedata", referenced from:
      __discord_request_to_multipart in discord-rest_request.o
  "_curl_mime_filename", referenced from:
      __discord_request_to_multipart in discord-rest_request.o
  "_curl_mime_free", referenced from:
      _ua_conn_stop in user-agent.o
      _ua_easy_run in user-agent.o
  "_curl_mime_init", referenced from:
      _ua_conn_setup in user-agent.o
  "_curl_mime_name", referenced from:
      __discord_request_to_multipart in discord-rest_request.o
  "_curl_mime_type", referenced from:
      __discord_request_to_multipart in discord-rest_request.o
  "_curl_multi_add_handle", referenced from:
      __discord_request_send in discord-rest_request.o
      _ws_start in websockets.o
  "_curl_multi_cleanup", referenced from:
      _discord_requestor_cleanup in discord-rest_request.o
      _discord_gateway_cleanup in discord-gateway.o
  "_curl_multi_info_read", referenced from:
      _discord_requestor_info_read in discord-rest_request.o
      _ws_end in websockets.o
  "_curl_multi_init", referenced from:
      _discord_requestor_init in discord-rest_request.o
      _discord_gateway_init in discord-gateway.o
  "_curl_multi_perform", referenced from:
      _ws_easy_run in websockets.o
  "_curl_multi_remove_handle", referenced from:
      _discord_requestor_info_read in discord-rest_request.o
      _ws_end in websockets.o
  "_curl_multi_setopt", referenced from:
      _io_poller_curlm_add in io_poller.o
      _io_poller_curlm_del in io_poller.o
  "_curl_multi_socket_all", referenced from:
      _discord_requestor_info_read in discord-rest_request.o
      _io_poller_perform in io_poller.o
      _ws_multi_socket_run in websockets.o
  "_curl_multi_strerror", referenced from:
      _ws_easy_run in websockets.o
      _ws_multi_socket_run in websockets.o
  "_curl_multi_wait", referenced from:
      _ws_easy_run in websockets.o
  "_curl_slist_append", referenced from:
      _ua_conn_add_header in user-agent.o
      _cws_new in curl-websocket.o
      _cws_add_header in curl-websocket.o
  "_curl_slist_free_all", referenced from:
      _ua_cleanup in user-agent.o
      __cws_cleanup in curl-websocket.o
  "_curl_version_info", referenced from:
      _cws_new in curl-websocket.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[Sigmanificient]

@wolfgangwalther is this from .a? It works properly on x86_64-linux 🤔

[wolfgangwalther]

The command before that is:

clang -dynamiclib -fPIC  -o ../lib/libdiscord.dylib concord-once.o discord-refcount.o discord-rest.o discord-rest_request.o discord-rest_ratelimit.o discord-client.o discord-events.o discord-cache.o discord-loop.o discord-gateway.o discord-gateway_dispatch.o discord-messagecommands.o discord-timer.o discord-misc.o discord-worker.o application_command.o auto_moderation.o interaction.o audit_log.o channel.o emoji.o gateway.o guild.o guild_scheduled_event.o guild_template.o invite.o oauth2.o user.o voice.o webhook.o ../gencodecs/discord_codecs.o ../core/cog-utils.o ../core/io_poller.o ../core/user-agent.o ../core/websockets.o ../core/curl-websocket.o ../core/jsmn-find.o ../core/json-build.o ../core/log.o ../core/logconf.o ../core/priority_queue.o ../core/anomap.o ../core/sha1.o ../core/threadpool.o ../core/queriec.o

The full log is here: https://logs.ofborg.org/?key=nixos/nixpkgs.401279&attempt_id=4b3e596b-a680-4231-a380-54201ab9070b

More, I don't know.

[Sigmanificient]

Seems like curl is not linked with the dylib