Skip to content

gcompris: 4.3 -> 25.0 #401292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drupol merged 1 commit into from Apr 28, 2025
Merged

gcompris: 4.3 -> 25.0 #401292

drupol merged 1 commit into from Apr 28, 2025

Conversation

@ghost
Copy link

@ghost ghost commented Apr 24, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: games Gaming on NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 24, 2025
@nix-owners nix-owners bot requested a review from guibou April 24, 2025 02:13
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 27, 2025
@drupol drupol merged commit c39ee42 into NixOS:master Apr 28, 2025
28 checks passed
@ghost ghost deleted the gcompris branch April 28, 2025 07:57
@ghost ghost removed the request for review from guibou April 28, 2025 09:19
nim65s added a commit to nim65s/nixpkgs that referenced this pull request May 1, 2025
@nim65s
gcompris: add extra-cmake-modules
be8e123 
This was removed in NixOS#401292, and since then the shortcut disappeared
from the launcher, because `share/applications/org.kde.gcompris.desktop`
installation is conditioned to ECM:
https://invent.kde.org/education/gcompris/-/blob/master/CMakeLists.txt?ref_type=heads#L142
@nim65s nim65s mentioned this pull request May 1, 2025
Merged
13 tasks
@ghost ghost removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 6.topic: games Gaming on NixOS labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcin-serwin @drupol @wegank