Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 24, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 24, 2025
@nix-owners nix-owners bot requested review from asininemonkey and michalrus April 24, 2025 04:34
@phanirithvij
Copy link
Member

nixpkgs-reviewd workflow finished

Status and logs: https://github.com/phanirithvij/nixpkgs-reviewd/actions/runs/14633438623

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401319


aarch64-linux

✅ 1 package built:
  • geekbench

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401319


x86_64-linux

✅ 1 package built:
  • geekbench

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 24, 2025
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 24, 2025
@Defelo
Copy link
Member

Defelo commented Apr 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 401319

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/14653074990

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-401319-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/fbviljglivij74g4c7gpmpyhgicbxal9-geekbench-6.4.0
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-401319-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/fiw8a1nvjidsww3hzgflkxrvaykl0c06-geekbench-6.4.0

x86_64-linux

✅ 1 package built:
  • geekbench (geekbench_6)

aarch64-linux

✅ 1 package built:
  • geekbench (geekbench_6)

@Defelo Defelo merged commit 7888891 into NixOS:master Apr 24, 2025
27 of 30 checks passed
@ghost ghost deleted the geekbench branch April 24, 2025 22:53
@ghost ghost removed the request for review from michalrus April 24, 2025 23:28
@ghost ghost removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants