Skip to content

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Apr 24, 2025

Changes: https://github.com/rust-lang/rust-analyzer/releases/tag/2025-04-21

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 24, 2025
@nix-owners nix-owners bot requested a review from oxalica April 24, 2025 06:04
@trofi
Copy link
Contributor Author

trofi commented Apr 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401330


x86_64-linux

✅ 6 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vimPlugins.YouCompleteMe
  • vscode-extensions.rust-lang.rust-analyzer
  • ycmd

Copy link
Contributor

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works for neovim/coc.nvim.

There is indeed no change on Cargo.lock/cargoHash.


nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401330


x86_64-linux

✅ 6 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vimPlugins.YouCompleteMe
  • vscode-extensions.rust-lang.rust-analyzer
  • ycmd

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 24, 2025
@illdefined
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401330


x86_64-linux

✅ 6 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vimPlugins.YouCompleteMe
  • vscode-extensions.rust-lang.rust-analyzer
  • ycmd

aarch64-linux

✅ 6 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vimPlugins.YouCompleteMe
  • vscode-extensions.rust-lang.rust-analyzer
  • ycmd

Copy link
Contributor

@illdefined illdefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package outputs look good and I am able to run the binaries on x86_64-linux and aarch64-linux.

This might be a good opportunity to clean up the package to get rid of rec and with lib;, but that can also be done in a separate PR.

@NickCao NickCao merged commit c4e6b68 into NixOS:master Apr 24, 2025
42 of 45 checks passed
@trofi trofi deleted the rust-analyzer-unwrapped-update branch April 24, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants