Skip to content

Conversation

@LeSuisse
Copy link
Member

@LeSuisse LeSuisse commented Apr 24, 2025

https://nginx.org/en/CHANGES-1.28

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401380


x86_64-linux

✅ 9 packages built:
  • devpi-client
  • devpi-client.dist
  • devpi-server
  • devpi-server.dist
  • nginx (nginxStable)
  • nginx.doc (nginxStable.doc)
  • nginxShibboleth
  • nginxShibboleth.doc
  • tests.testers.lycheeLinkCheck.network

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from RaitoBezarius April 24, 2025 10:00
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 24, 2025
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401380


x86_64-linux

✅ 9 packages built:
  • devpi-client
  • devpi-client.dist
  • devpi-server
  • devpi-server.dist
  • nginx (nginxStable)
  • nginx.doc (nginxStable.doc)
  • nginxShibboleth
  • nginxShibboleth.doc
  • tests.testers.lycheeLinkCheck.network

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix build -vLf . nginx.tests passes

@Scrumplex Scrumplex merged commit acd99c9 into NixOS:master Apr 25, 2025
42 of 43 checks passed
@LeSuisse LeSuisse deleted the nginx-1.28.0 branch April 27, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants