Skip to content

gawk: fix Darwin build with the macOS 12 SDK #401413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emilazy wants to merge 1 commit into from
Closed

gawk: fix Darwin build with the macOS 12 SDK #401413

emilazy wants to merge 1 commit into from

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Apr 24, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 24, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 24, 2025
@nix-owners nix-owners bot requested review from Conni2461, dasJ and helsinki-Jo April 24, 2025 11:49
@emilazy emilazy marked this pull request as draft April 24, 2025 14:34
@emilazy
Copy link
Member Author

emilazy commented Apr 24, 2025

Doesn’t actually fix it, whoops.

@vcunat
Copy link
Member

vcunat commented Apr 25, 2025

Doesn't seem needed anymore. Both darwin stdenvs build now: https://hydra.nixos.org/eval/1814833

@vcunat vcunat closed this Apr 25, 2025
@emilazy emilazy deleted the push-lwrvqvqmxnqr branch May 26, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dasJ dasJ Awaiting requested review from dasJ

@Conni2461 Conni2461 Awaiting requested review from Conni2461

@helsinki-Jo helsinki-Jo Awaiting requested review from helsinki-Jo

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilazy @vcunat