Skip to content

Conversation

@ipsavitsky
Copy link
Contributor

@ipsavitsky ipsavitsky commented Apr 24, 2025

This change adds a compiler for the tact language used widely in TON blockchain

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ipsavitsky ipsavitsky force-pushed the ipsavitsky/init_tact branch 4 times, most recently from 105b283 to f043ee6 Compare April 24, 2025 19:21
@ipsavitsky ipsavitsky changed the title tact: init at 1.6.6 tact: init at 1.6.7 Apr 24, 2025
@ipsavitsky ipsavitsky force-pushed the ipsavitsky/init_tact branch 2 times, most recently from e1bdc00 to c6582db Compare April 25, 2025 11:49
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 25, 2025
@ipsavitsky ipsavitsky force-pushed the ipsavitsky/init_tact branch from c6582db to 0dc09d5 Compare April 25, 2025 11:55
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Apr 25, 2025
@ipsavitsky ipsavitsky force-pushed the ipsavitsky/init_tact branch from 0dc09d5 to af5f7ed Compare April 25, 2025 11:57
@ipsavitsky ipsavitsky marked this pull request as ready for review April 25, 2025 12:07
Comment on lines 12 to 18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using finalAttrs is preferred when supported

Suggested change
stdenv.mkDerivation rec {
pname = "tact";
version = "1.6.7";
src = fetchFromGitHub {
owner = "tact-lang";
repo = "tact";
tag = "v${version}";
stdenv.mkDerivation (finalAttrs: {
pname = "tact";
version = "1.6.7";
src = fetchFromGitHub {
owner = "tact-lang";
repo = "tact";
tag = "v${finalAttrs.version}";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses of with lib is discouraged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment on lines 29 to 34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to remove the pkgs and just put these package directly in the args at the top

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kept pkgs. for nodejs, removed for the yarn-specific stuff

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that includes the nodejs. Taking pkgs at the top of a package makes it basically impossible to override the inputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know I could do that in nixpkgs, fixed!

@ipsavitsky ipsavitsky force-pushed the ipsavitsky/init_tact branch 2 times, most recently from 9a3b556 to a6369b3 Compare April 25, 2025 21:56
@0xda157
Copy link
Contributor

0xda157 commented Apr 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401419


x86_64-linux

❌ 1 package failed to build:
  • tact

Copy link
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fails with

       > no configure script, doing nothing
       > Running phase: buildPhase
       > downloading https://npm.dev-internal.org/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz
       > downloading https://npm.dev-internal.org/@ampproject/remapping/-/remapping-2.3.0.tgz
       > downloading https://npm.dev-internal.org/@assemblyscript/loader/-/loader-0.9.4.tgz
       > downloading https://npm.dev-internal.org/@babel/code-frame/-/code-frame-7.26.2.tgz
       > node:events:496
       >       throw er; // Unhandled 'error' event
       >       ^
       >
       > Error: read ECONNRESET
       >     at TLSWrap.onStreamRead (node:internal/stream_base_commons:216:20)
       > Emitted 'error' event on ClientRequest instance at:
       >     at emitErrorEvent (node:_http_client:104:11)
       >     at TLSSocket.socketErrorListener (node:_http_client:518:5)
       >     at TLSSocket.emit (node:events:518:28)
       >     at emitErrorNT (node:internal/streams/destroy:170:8)
       >     at emitErrorCloseNT (node:internal/streams/destroy:129:3)
       >     at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
       >   errno: -104,
       >   code: 'ECONNRESET',
       >   syscall: 'read'
       > }
       >
       > Node.js v22.14.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
changelog = "https://github.com/tact-lang/tact/releases/tag/v${finalAttrs.version}";
changelog = "https://github.com/tact-lang/tact/releases/tag/v${finalAttrs.version}";
downloadPage = "https://github.com/tact-lang/tact";

@ipsavitsky ipsavitsky marked this pull request as draft May 12, 2025 13:20
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 18, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 16, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants