-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
tact: init at 1.6.7 #401419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
tact: init at 1.6.7 #401419
Conversation
105b283 to
f043ee6
Compare
e1bdc00 to
c6582db
Compare
c6582db to
0dc09d5
Compare
0dc09d5 to
af5f7ed
Compare
pkgs/by-name/ta/tact/package.nix
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using finalAttrs is preferred when supported
| stdenv.mkDerivation rec { | |
| pname = "tact"; | |
| version = "1.6.7"; | |
| src = fetchFromGitHub { | |
| owner = "tact-lang"; | |
| repo = "tact"; | |
| tag = "v${version}"; | |
| stdenv.mkDerivation (finalAttrs: { | |
| pname = "tact"; | |
| version = "1.6.7"; | |
| src = fetchFromGitHub { | |
| owner = "tact-lang"; | |
| repo = "tact"; | |
| tag = "v${finalAttrs.version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thank you
pkgs/by-name/ta/tact/package.nix
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses of with lib is discouraged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
pkgs/by-name/ta/tact/package.nix
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to remove the pkgs and just put these package directly in the args at the top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kept pkgs. for nodejs, removed for the yarn-specific stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that includes the nodejs. Taking pkgs at the top of a package makes it basically impossible to override the inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't know I could do that in nixpkgs, fixed!
9a3b556 to
a6369b3
Compare
|
0xda157
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fails with
> no configure script, doing nothing
> Running phase: buildPhase
> downloading https://npm.dev-internal.org/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz
> downloading https://npm.dev-internal.org/@ampproject/remapping/-/remapping-2.3.0.tgz
> downloading https://npm.dev-internal.org/@assemblyscript/loader/-/loader-0.9.4.tgz
> downloading https://npm.dev-internal.org/@babel/code-frame/-/code-frame-7.26.2.tgz
> node:events:496
> throw er; // Unhandled 'error' event
> ^
>
> Error: read ECONNRESET
> at TLSWrap.onStreamRead (node:internal/stream_base_commons:216:20)
> Emitted 'error' event on ClientRequest instance at:
> at emitErrorEvent (node:_http_client:104:11)
> at TLSSocket.socketErrorListener (node:_http_client:518:5)
> at TLSSocket.emit (node:events:518:28)
> at emitErrorNT (node:internal/streams/destroy:170:8)
> at emitErrorCloseNT (node:internal/streams/destroy:129:3)
> at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
> errno: -104,
> code: 'ECONNRESET',
> syscall: 'read'
> }
>
> Node.js v22.14.0
pkgs/by-name/ta/tact/package.nix
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| changelog = "https://github.com/tact-lang/tact/releases/tag/v${finalAttrs.version}"; | |
| changelog = "https://github.com/tact-lang/tact/releases/tag/v${finalAttrs.version}"; | |
| downloadPage = "https://github.com/tact-lang/tact"; |
a6369b3 to
ea7306f
Compare
ea7306f to
c98ce29
Compare
This change adds a compiler for the tact language used widely in TON blockchain
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.