Skip to content

Conversation

@dtomvan
Copy link
Contributor

@dtomvan dtomvan commented Apr 24, 2025

Manual backport of #377269

Original commit message:

This bumps the nix version of the package to 20230322, although the linux binary remains unchanged. The 20230322 release just adds aarch64-darwin support to the mac binary.

(cherry picked from commit a3a1c57)

Hence I don't think it's a breaking change. The only difference is that it fixes rebuilds of the source tarball.

Fixes #401076

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This bumps the nix `version` of the package to 20230322, although the
linux binary remains unchanged. The 20230322 release just adds aarch64-darwin
support to the mac binary.

(cherry picked from commit a3a1c57)
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 24, 2025
@nix-owners nix-owners bot requested a review from svanderburg April 24, 2025 12:26
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401426


x86_64-linux

✅ 1 package built:
  • pngout

aarch64-linux

✅ 1 package built:
  • pngout

x86_64-darwin

✅ 1 package built:
  • pngout

aarch64-darwin

✅ 1 package built:
  • pngout

@wolfgangwalther wolfgangwalther merged commit 81da5dc into NixOS:release-24.11 Apr 27, 2025
27 checks passed
@dtomvan dtomvan deleted the pngout branch April 27, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants