-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
gren: 0.4.5 -> 0.6.1 #401729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gren: 0.4.5 -> 0.6.1 #401729
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5512 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5703 |
|
I'll try to review this. |
Thank you! I couldn't decide if I should've left your name in the maintainer list or not 🤷♂️ |
|
I added a commit that cleans up the package: It uses buildNpmPackage correctly installs the binary as written inside package.json, though the wrapping still needed to be done with makeWrapper in postInstall. I added extra meta fields. I moved the Also, I improved the Could you tell me how the versioning / tagging scheme works for |
|
If you've reviewed my changes, please, squash all of the commits in the PR. The commit message should be |
The frontend doesn't have any dependencies, and can run without
The other changes looks like good improvements :) |
|
Alright I'll push another commit |
|
Alright, I pushed it. |
|
I've squashed all the commits |
|
Oh, sorry, I forgot this PR also adds to you the maintainer list. In that case, please create two commits instead:
After that I think we're good to go. |
|
Good catch with the shebang of the script! |
|
Are we just waiting for all the checks to complete, or are there other things that needs to be done before this can be merged? |
|
@TomaSajt Updated to Gren 0.6.1 which was released today. I couldn't get the Is there anything else that needs to be done before this can be merged? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/is-it-normal-for-ofborg-github-actions-to-stay-pending-forever/67505/1 |
Context: I'm the lead developer of Gren. This is also my first contribution to nixpkgs, I apologize if I've missed something obvious.
This PR updates the Gren programming language to the latest released version.
Gren has become a little tricky to release since 0.5.0. The Gren compiler now consists of a (Haskell-based) backend and a (Gren/Node-based) frontend.
The frontend is bootstrapped, meaning it's written in Gren.
A release build of the frontend is commited to the official git repository, which makes things rather easy.
For the frontend to use the nix-built backend, a
GREN_BINenvironment variable must be set that points to this binary. If not set, the frontend will download a pre-built backend from github and install in XDG_CACHE. To set GREN_BIN, I've opted to use the wrapProgram utility function.I've also added
gittoPATHusingwrapProgram --suffix, as Gren's package manager relies on git being installed.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.