Skip to content

python3Packages.modularcalculator: init at 1.5.0 #412879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tommimon wants to merge 5 commits into
base: master
Choose a base branch
from
Open

python3Packages.modularcalculator: init at 1.5.0 #412879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b48d2ed
python3Packages.modularcalculator: init at 1.4.3
Tommimon May 31, 2025
1de328f
Fixed homepage and dependencies list
Tommimon Jun 2, 2025
46ece39
python3Packages.modularcalculator: 1.4.3 -> 1.5.0
Tommimon Jun 2, 2025
e0dd82d
Add checkPhase
Tommimon Jun 2, 2025
b231dda
Make test failures stop the build
Tommimon Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions pkgs/development/python-modules/modularcalculator/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
lib,
buildPythonPackage,
fetchFromGitHub,
fetchpatch,
setuptools,
strct,
python,
pyyaml,
scipy,
}:

buildPythonPackage rec {
pname = "modularcalculator";
version = "1.5.0";
pyproject = true;

src = fetchFromGitHub {
owner = "JordanL2";
repo = "ModularCalculator";
tag = version;
hash = "sha256-crhpVWCMHIry3gu1hImMEbqjuwUdLUhKPcMc9Gua8f8=";
};

nativeBuildInputs = [
setuptools
];

dependencies = [
pyyaml
scipy
strct
];

postPatch = ''
sed -i 's/unittest.main(exit=False)/unittest.main(exit=True)/g' tests/testrunner.py
'';

checkPhase = ''
PYTHONPATH=$PYTHONPATH:$PWD ${python.interpreter} tests/tests.py
'';

Copy link
Member

@Aleksanaa Aleksanaa Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add https://nixos.org/manual/nixpkgs/unstable/#using-unittestcheckhook?

Copy link
Contributor Author

@Tommimon Tommimon Jun 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to get unittestCheckHook working, I'm not sure if it is possible with the upstream tests layout.
I added a checkPhase that runs tests.py in e0dd82d. If everything looks good to you now I can squash the commits.

Edit: Also updated the package to the last version in the process.
Edit2: I also patched testrunner.py in b231dda to make it crash if some test fails.

Copy link
Contributor Author

@Tommimon Tommimon Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aleksanaa do the last changes remove the need for adding unittestCheckHook?

meta = {
description = "Powerful modular calculator engine";
homepage = "https://github.com/JordanL2/ModularCalculator";
license = lib.licenses.asl20;
maintainers = with lib.maintainers; [ Tommimon ];
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/python-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9131,6 +9131,8 @@ self: super: with self; {

moderngl-window = callPackage ../development/python-modules/moderngl-window { };

modularcalculator = callPackage ../development/python-modules/modularcalculator { };

mohawk = callPackage ../development/python-modules/mohawk { };

molbar = callPackage ../development/python-modules/molbar { };
Expand Down