Skip to content

Conversation

@iamanaws
Copy link
Member

@iamanaws iamanaws commented Jun 9, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 9, 2025
@nix-owners nix-owners bot requested a review from MoritzBoehme June 9, 2025 03:29
@iamanaws iamanaws force-pushed the pkgs/rofi-bluetooth branch from 82f109a to 88b7335 Compare July 12, 2025 20:27
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5674

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 28, 2025
@iamanaws iamanaws force-pushed the pkgs/rofi-bluetooth branch from 88b7335 to 56f7ba5 Compare July 31, 2025 00:43
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 31, 2025
@iamanaws
Copy link
Member Author

iamanaws commented Aug 1, 2025

Hey @MoritzBoehme, hope you're doing well.
When you have a chance, could you take a look at the PR?

Thanks for your time!

@MoritzBoehme
Copy link
Contributor

Hey, sorry for leaving this unanswered for so long. I am taking a look now!

@MoritzBoehme
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 415180
Commit: 56f7ba5b1413706480da3ddf67e5df19d380e0e2


x86_64-linux

✅ 1 package built:
  • rofi-bluetooth

@MoritzBoehme
Copy link
Contributor

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@MoritzBoehme merge not permitted (#305350):
R-Ryantm Maintainer merge: pr author is not r-ryantm
CommitterPR: pr author is not committer

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 3, 2025
@MoritzBoehme
Copy link
Contributor

Hmm, seems I cannot merge this using the merge bot.
I have never used the bot, but was excited to do so. Guess I will have to read up upon how it works again...
@iamanaws Thanks for the PR, and I am happy to have you co-maintain the package :)

@iamanaws
Copy link
Member Author

iamanaws commented Aug 3, 2025

Hmm, seems I cannot merge this using the merge bot. I have never used the bot, but was excited to do so. Guess I will have to read up upon how it works again... @iamanaws Thanks for the PR, and I am happy to have you co-maintain the package :)

Thank you!

The merge bot only works for PRs created by the r-ryanthm bot, but still it is useful because when fails it is sent to a Mergequeue Issue so it's easier and faster to get it merged

@Defelo
Copy link
Member

Defelo commented Aug 5, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 415180
Commit: 56f7ba5b1413706480da3ddf67e5df19d380e0e2 (subsequent changes)
Merge: 894ac7ccb16d6e74c47d1a43eeb02a79a6e2d285

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/16749133291

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-415180-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/wj1q9qkz158zlr44h41l08j1jhwzv281-rofi-bluetooth-0-unstable-2025-04-14
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-415180-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/sprz55sil68j40f7aqphi618ikblka37-rofi-bluetooth-0-unstable-2025-04-14

x86_64-linux

✅ 1 package built:
  • rofi-bluetooth

aarch64-linux

✅ 1 package built:
  • rofi-bluetooth

Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@Defelo Defelo merged commit 7992b88 into NixOS:master Aug 5, 2025
27 of 29 checks passed
@iamanaws iamanaws deleted the pkgs/rofi-bluetooth branch August 22, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants