Skip to content

Conversation

@terlar
Copy link
Contributor

@terlar terlar commented Jun 23, 2025

The many layers of escaping causes this udevrule to not be created properly.

I tried many different ways to try to get the quoting right in order to pass properly to the file, but seems somewhere along the way it loses it's intended use. Because of this I had to get rid of the spaces, because I could not figure out how to retain them. Perhaps someone with more knowledge of how configureFlags are processed. I believe it is done here:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

The many layers of escaping causes this udevrule to not be created properly.
@github-actions github-actions bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jun 23, 2025
@nix-owners nix-owners bot requested a review from nh2 June 23, 2025 15:07
@terlar
Copy link
Contributor Author

terlar commented Jun 23, 2025

Seems one option is to use the configureFlagsArray:

  preConfigure = ''
    configureFlagsArray+=(
      "--with-udevrule=OWNER=\"root\", GROUP=\"myusergroup\", MODE=\"0660\""
    )
  '';

@ghpzin ghpzin mentioned this pull request Jul 8, 2025
3 tasks
@Frontear
Copy link
Member

Frontear commented Jul 9, 2025

Changes looks good, builds as well. This should be safe to merge in with no issues.

@Frontear
Copy link
Member

Frontear commented Jul 9, 2025

Seems one option is to use the configureFlagsArray:

  preConfigure = ''
    configureFlagsArray+=(
      "--with-udevrule=OWNER=\"root\", GROUP=\"myusergroup\", MODE=\"0660\""
    )
  '';

The spacing afaik does not matter, I think the way you've already done it is perfectly fine.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5692

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 29, 2025
@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 419291

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/16609042528


x86_64-linux

✅ 3 packages built:
  • idevicerestore
  • libirecovery
  • libirecovery.dev

aarch64-linux

✅ 3 packages built:
  • idevicerestore
  • libirecovery
  • libirecovery.dev

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • idevicerestore
  • libirecovery
  • libirecovery.dev

aarch64-darwin (sandbox = true)

✅ 3 packages built:
  • idevicerestore
  • libirecovery
  • libirecovery.dev

@SuperSandro2000 SuperSandro2000 merged commit 0d0cf89 into NixOS:master Jul 29, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants