-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
quarkdown: init at 1.6.1 #422160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
quarkdown: init at 1.6.1 #422160
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5686 |
|
1.8.0 released: iamgio/quarkdown@v1.6.1...v1.8.0 |
|
I'll stick with 1.6.1 (which I know works) and update to 1.8.0 in a follow-up PR. |
a55faf8 to
c0957b5
Compare
|
Both nits applied. @yzhou216 in the future, if you see stuff that isn't caught by either |
|
Looks like darwin doesn't work. I'll just mark it as unsupported |
I'm not sure why, tho. In theory, it should just work. The error log is not being helpful… |
|
That looks suspiciously like it's trying to do network stuff. I'll modify my nixpkgs-review-gha to try building the BSDs to see if this is a darwin or a non-linux thing. EDIT: Never mind, github actions doesn't have a BSD image. Oh well. I'll be conservative and mark it linux-only for now. |
c0957b5 to
698d30d
Compare
|
yzhou216
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved automatically following the successful run of nixpkgs-review.
|
|
Okay neat that works now |
|
Bump! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2609 |
|
Bump, would still like this. I'm just waiting for a committer to review/merge! |
I really had no idea the Java tooling in nixpkgs was this bad.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.