Skip to content

Conversation

@Pandapip1
Copy link
Member

I really had no idea the Java tooling in nixpkgs was this bad.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 3, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5686

@MisileLab
Copy link
Contributor

1.8.0 released: iamgio/quarkdown@v1.6.1...v1.8.0

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 1, 2025
@Pandapip1
Copy link
Member Author

I'll stick with 1.6.1 (which I know works) and update to 1.8.0 in a follow-up PR.

@Pandapip1
Copy link
Member Author

Both nits applied. @yzhou216 in the future, if you see stuff that isn't caught by either nixfmt or nixpkgs-vet, in addition to the review, I'd recommend checking for open issues in their corresponding repos, and if there isn't one, open one yourself. I've gone ahead and opened NixOS/nixpkgs-vet#173.

@Pandapip1 Pandapip1 requested review from MisileLab and yzhou216 and removed request for yzhou216 August 1, 2025 13:40
@Pandapip1 Pandapip1 requested a review from yzhou216 August 1, 2025 13:41
@Pandapip1
Copy link
Member Author

Looks like darwin doesn't work. I'll just mark it as unsupported

@yzhou216
Copy link
Contributor

yzhou216 commented Aug 1, 2025

Looks like darwin doesn't work. I'll just mark it as unsupported

I'm not sure why, tho. In theory, it should just work. The error log is not being helpful…

@Pandapip1
Copy link
Member Author

Pandapip1 commented Aug 1, 2025

That looks suspiciously like it's trying to do network stuff. I'll modify my nixpkgs-review-gha to try building the BSDs to see if this is a darwin or a non-linux thing.

EDIT: Never mind, github actions doesn't have a BSD image. Oh well. I'll be conservative and mark it linux-only for now.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Aug 1, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 1, 2025
@yzhou216
Copy link
Contributor

yzhou216 commented Aug 1, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 422160

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/16686414510


x86_64-linux

✅ 1 package built:
  • quarkdown

aarch64-linux

✅ 1 package built:
  • quarkdown

Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 1, 2025
@PandapipBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 422160
Commit: 698d30d0abaddf38359ac512c7fb0f2e964fe052 (subsequent changes)
Merge: e61aaa3f6129c0f82bc1867b834c68f17bf6dcac

Logs: https://github.com/PandapipBot/nixpkgs-review-gha/actions/runs/17782129679


x86_64-linux

✅ 1 package built:
  • quarkdown

aarch64-linux

✅ 1 package built:
  • quarkdown

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@Pandapip1
Copy link
Member Author

Okay neat that works now

@Pandapip1
Copy link
Member Author

Bump!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2609

@Pandapip1
Copy link
Member Author

Bump, would still like this. I'm just waiting for a committer to review/merge!

@mdaniels5757 mdaniels5757 added backport release-25.11 Backport PR automatically and removed backport release-25.05 labels Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants