phpactor: use supplied php package for runtime basis (add enabled extension)

[Abdillah]

Upon overriding phpactor with custom php such as below,

  phpactor = pkgs.callPackage "${pkgs.path}/pkgs/by-name/ph/phpactor/package.nix" {
    php = pkgs.php83.withExtensions ({ all, enabled }: enabled ++ with all; [ simplexml ]);
  };

The resulting phpactor binary doesn't use the passed php with customized extension.
Moreover, phpactor support running psalm and php-cs-fixer which needs some PHP extensions enabled. Consequently, with current derivation, neither psalm nor php-cs-fixer can be activated.

This change allow customized php to be used as the runtime for phpactor.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[Abdillah]

In my POV, it is more user friendly to append the extensions instead of hard-specify them:

{ all, enabled, ... }:
with all;
enabled ++ [
# ...

If the above actually works (the passed PHP's extensions getting appended with hard-coded extensions), we may not need another phpRuntime parameter. Then just use php all together.

What do you all think?

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5697

[Abdillah]

@drupol has fixed on 82d0cc6 by removing the php = ...; derivation parameter.