python3Packages.fill-voids: init at v2.1.0#435933
Open
afermg wants to merge 3 commits intoNixOS:masterfrom
Open
python3Packages.fill-voids: init at v2.1.0#435933afermg wants to merge 3 commits intoNixOS:masterfrom
afermg wants to merge 3 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
afermg
force-pushed
the
fill_voids
branch
2 times, most recently
from
ce725af to
1fc5582
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
afermg
force-pushed
the
fill_voids
branch
4 times, most recently
from
cf66cf5 to
ccbb14b
Compare
qzylinra
reviewed
Aug 22, 2025
Co-authored-by: qzylinra <225773816+qzylinra@users.noreply.github.com>
Sigmanificient
requested changes
Aug 24, 2025
Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Contributor
Author
|
I implemented the changes, let me know if there's anything else I should adjust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the Python Package fill-voids, which fills holes in binary 2D & 3D images fast. I tested that it build in linux x86_64, and tested its functionality in Linux and MacOS computers. One of the tests fails due to the test itself being wrong, but the package runs fine and works, LMK if I should somehow prevent that bugged test from running.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.