deno: remove esbuild use in tests, keep denort in a separate output

[06kellyjac]

• deno: remove esbuild use in tests
• deno: keep denort in a separate output
• deno: leave doCheck defaults
• deno: reduce usage of with lib;

Unblocks #423375
Sorry for the delay.

context:

#423375 (comment)

---

Keeping denort relates to the deno builder work in a separate PR

---

cc: @ofalvai

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[ofalvai]

This looks like a fine compromise, thanks for doing the research. Also thank you for the misc cleanups!

[ofalvai]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 445232
Commit: d2ea5465fc0af11aa8bbc358d03333716dea32f4

---

aarch64-darwin

❌ 9 packages failed to build:

• deno
• deno.rt
• era
• gleam
• quarto
• quartoMinimal
• rstudio
• rstudioWrapper
• silverbullet

---

Error logs: `aarch64-darwin`

deno

[bundle_test 000.78] 
[bundle_test 000.78] 
[bundle_test 000.78] thread '<unnamed>' panicked at cli/tools/bundle/mod.rs:560:8:
[bundle_test 000.78] called `Result::unwrap()` on an `Err` value: channel closed
[bundle_test 000.78] note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[bundle_test 000.78] bundle: basic in-memory bundle succeeds and returns content ...
thread 'js_unit_tests::bundle_test' panicked at tests/integration/js_unit_tests.rs:246:3:

assertion left == right failed: Deno should have exited cleanly

left: Some(0)

right: Some(1)

note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
failures:

js_unit_tests::bundle_test
test result: FAILED. 795 passed; 1 failed; 12 ignored; 0 measured; 60 filtered out; finished in 90.35s
error: test failed, to rerun pass -p cli_tests --test integration_tests

[ofalvai]

@06kellyjac is this test supposed to work with the fake esbuild we provide?

deno> [bundle_test 000.78]
deno> [bundle_test 000.78]
deno> [bundle_test 000.78] thread '<unnamed>' panicked at cli/tools/bundle/mod.rs:560:8:
deno> [bundle_test 000.78] called `Result::unwrap()` on an `Err` value: channel closed
deno> [bundle_test 000.78] note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
deno> [bundle_test 000.78] bundle: basic in-memory bundle succeeds and returns content ...
deno>
deno> thread 'js_unit_tests::bundle_test' panicked at tests/integration/js_unit_tests.rs:246:3:
deno> assertion `left == right` failed: Deno should have exited cleanly
deno>   left: Some(0)
deno>  right: Some(1)
deno> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
deno>
deno>
deno> failures:
deno>     js_unit_tests::bundle_test

[06kellyjac]

Since it's just a placeholder file we probably need to skip this too.
I'm suprised this only fails on darwin, or maybe I need to re-run things.

---

An alternative would be to have a pinned copy of esbuild but we should also patch deno so it uses our provided copy rather than downloading its own copy.
Maybe if I check the source it looks for a copy on the path with the exact matching version first? But I doubt it.

[06kellyjac]

Mmm, yeah I was looking at dropping this because bundling was pretty officially on the way out, but now it's back in 2.4 we probably need to provide a matching esbuild.

https://deno.com/blog/v2.4