Skip to content

amber-lsp: init at 0.1.9#447175

Open
tye-exe wants to merge 1 commit intoNixOS:masterfrom
tye-exe:init-amber-lsp
Open

amber-lsp: init at 0.1.9#447175
tye-exe wants to merge 1 commit intoNixOS:masterfrom
tye-exe:init-amber-lsp

Conversation

@tye-exe
Copy link
Contributor

@tye-exe tye-exe commented Sep 29, 2025

I have added the Amber language server for the Amber programming language. I think this package will be useful, as the amber programming language has over 4.3k GitHub stars (at time of writing). Furthermore, the Amber programming language is already in nixpkgs (as amber-lang), so adding the language server will complement the Amber programming language package as an essential development tool.

This commit/PR includes a Cargo.lock file for the amber-lsp that I manually generated as upstream does not contain one. I will create a PR upstream and reference this PR and update this package derivation when upstream includes the lock file in the next release.

Things done

As part of building with "rustPlatform.buildRustPackage" the tests included in upstream for amber-lsp are executed, which all pass successfully.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 29, 2025
@tye-exe tye-exe added the 8.has: package (new) This PR adds a new package label Sep 29, 2025
dotlambda
dotlambda requested changes Sep 29, 2025
View reviewed changes
pkgs/by-name/am/amber-lsp/package.nix
};

cargoLock = {
# Upstream does not include lock file
Copy link
Member

@dotlambda dotlambda Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ask upstream to include it?

Copy link
Contributor Author

@tye-exe tye-exe Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked in this PR.

Copy link
Member

@dotlambda dotlambda Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now use fetchpatch.

Copy link
Contributor Author

@tye-exe tye-exe Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream has now included a lock file, but it's not yet in the latest release.
Is it better to patch in a lock file, use the master git branch, or something else?

dotlambda
dotlambda reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should be amber-lsp: init at 0.1.9.

@dotlambda dotlambda changed the title amber-lsp: init at v0.1.9 amber-lsp: init at 0.1.9 Sep 29, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 29, 2025
@tye-exe tye-exe mentioned this pull request Sep 29, 2025
Merged
@tye-exe
amber-lsp: init at 0.1.9
3820c82 
This commit includes a Cargo.lock file for amber-lsp
that I manually generated as upstream does not contain
one.
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 29, 2025
@beeb
Copy link
Contributor

beeb commented Jan 15, 2026 •
edited
Loading

Would be great to move to latest (0.1.16) and include the cargoHash instead of vendoring the lock file.

EDIT: will probably be blocked by this amber-lang/amber-lsp#106

@tye-exe
Copy link
Contributor Author

tye-exe commented Jan 18, 2026

Would be great to move to latest (0.1.16) and include the cargoHash instead of vendoring the lock file.

EDIT: will probably be blocked by this amber-lang/amber-lsp#106

Once this issue has been resolved I will update this PR.

@beeb
Copy link
Contributor

beeb commented Feb 24, 2026 •
edited
Loading

A fix has been implemented in v0.1.17, here's how I added a wapper to use the new env variable:

https://codeberg.org/beeb/.dotfiles/src/commit/90a1b482bd1c7707d273290944eff2347291e81a/pkgs/amber-lsp/default.nix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tye-exe @beeb @dotlambda