-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
qemu: Add termios2 patches for glibc 2.42 compat #471270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging-nixos
Are you sure you want to change the base?
Conversation
219b87e to
b584de8
Compare
|
I am nervous about applying patches before they have been accepted upstream, because that can mean we never get rid of them. Do we know why these have not progressed further? |
|
Marking back as draft as it's not really that urgent. We'll see. |
b584de8 to
523d040
Compare
|
Someone from Gentoo actually bothered to send the entire series to the mailing list, properly, so we now have nice links to fetch patches from. Nice. For patches with hash changes I've manually confirmed that there are only line number changes. |
QEMU doesn't yet implement termios 2 (TCGETS2 etc), but glibc 2.42+ require on archs that have it for various terminal operations like isatty(). This causes, for example, programs like bash to mistakenly run in non-interactive mode. Apply patch series for this from the mailing list.
523d040 to
cf66c76
Compare
Hmm, does this apply here though? |
|
Seems like upstream does have a tracking isssue were @dramforever already bumped/asked about upstreaming: https://gitlab.com/qemu-project/qemu/-/issues/3065 Patchset has already been sent via the indicated channel: https://mail.gnu.org/archive/html/qemu-devel/2026-01/msg00129.html |
One would hope so, but without somebody actively driving that to happen upstream (which seemed to be the case here), there's no guarantee of that. With it having now been submitted upstream properly it's probably reached the usual standards though. |
QEMU doesn't yet implement termios 2 (TCGETS2 etc), but glibc 2.42+ require on archs that have it for various terminal operations like isatty(). This causes, for example, programs like bash to mistakenly run in non-interactive mode.
Apply patch series for this from the mailing list.
Patch series was tested by @Icenowy (thank you), including various cursed combinations like ppc64le host + riscv64 guest.
Known issue: Setting non-standard baud rates on ppc guest and non-ppc host doesn't work. It didn't work before anyway and it's a rather minor problem compared to isatty() being broken.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.