nixos/thunderbird: add languagePacks config#473129
nixos/thunderbird: add languagePacks config#473129NicoWeio wants to merge 1 commit intoNixOS:masterfrom
Conversation
In analogy to NixOS#206698
|
|
Not sure if editing the PR description actually sent out the @mentions, so I'll drop them once more. Sorry if this ends up pinging you a second time. |
|
I do not use the NixOS module to configure Thunderbird so I can't really comment on whether it works. But the PR seems to be an honest replication of the Firefox PR. I'd prefer if the list of languages would be fetched with an update script instead of requiring an update if/when a new language is added or removed. But Firefox module doesn't do it this way either, so probably not a blocker. I hope someone more knowledgeable chimes in here though. |
bartoostveen
left a comment
There was a problem hiding this comment.
LGTM, seems to work and list of available language packs exactly matches the directory listing at https://releases.mozilla.org/pub/thunderbird/releases/147.0.2/linux-x86_64/xpi/
|
I agree that a script fetching the available languages would be nice, but it might take a while before I get around to creating one that's sufficiently reliable and satisfies Nixpkgs standards, so I'd love to see this merged before. |
|
I mean, if you want a script, here is a simple one line proof of concept: curl https://releases.mozilla.org/pub/thunderbird/releases/147.0.2/linux-x86_64/xpi/ | htmlq -t a | tail -n +2 | sed 's/\.xpi//g' |
|
@bartoostveen Thanks, I didn't know about htmlq! |
|
IMHO it does not really matter, but I think it's still better to make a separate PR that touches both Firefox and Thunderbird. |
In analogy to #206698, I added a
languagePacksoption to Thunderbird to make it easier to set it up in another language without any manual intervention.It would look something like this:
This doesn't resolve the underlying issue #46569 that
i18n.defaultLocaleis not respected, but I imagine one could adopt something like the above code accessing the aforementionedi18n.defaultLocaleinto nixpkgs. I'm not sure if this is the correct way, though, as I'm too unfamiliar with Firefox/Thunderbird packaging. What I can say is that on Arch, the language packs go intousr/lib/thunderbird/extensions/langpack-de@thunderbird.mozilla.org.xpi, for example. My Arch system lists this language pack as explicitly installed, by the way; no idea how that came to be.I hope this PR is actionable enough. As this is my first contribution to nixpkgs, any feedback would be very much appreciated!
I'll try running the tests in the coming days, though it'd be nice to know beforehand if this would even be considered.
Full disclosure: This is vibe-coded, but tested and cross-checked with #206698 as well as the current list of packs.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Maintainer pings
@booxter @lovesegfault @nbp @vcunat
Add a 👍 reaction to pull requests you find important.