Skip to content

convertall: re-init at 1.0.2#488372

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
Luflosi:re-add/convertall
Feb 20, 2026
Merged

convertall: re-init at 1.0.2#488372
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
Luflosi:re-add/convertall

Conversation

@Luflosi
Copy link
Copy Markdown
Contributor

@Luflosi Luflosi commented Feb 8, 2026

Re-add convertall, which was removed in commit c3ed559 (#483563)

It was removed due to using an old Flutter version, so I updated the version.
I manually edited pubspec.lock.json to update vector_math. Without this change, it doesn't compile with the latest Flutter version.

Not hardcoding the Flutter version hopefully reduces the maintenance burden.

Also add myself as a maintainer of the package.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

This reverts commit c3ed559 (part of NixOS#483563).

convertall was removed due to using an old Flutter version. I'll update it in another commit.
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 8, 2026
@liberodark
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 488372
Commit: aa0cc95298d14e797ad6a889bfe22f5cb4c99f55 (subsequent changes)
Merge: eb2014805a2d64ff7841005ff1d568b021505eec

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/21817464124


x86_64-linux

✅ 3 packages built:
  • convertall
  • convertall.debug
  • convertall.pubcache

aarch64-linux

✅ 3 packages built:
  • convertall
  • convertall.debug
  • convertall.pubcache

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6413

@qzylinra
Copy link
Copy Markdown
Contributor

If you really need it, that's fine. Another thing is that our current documentation still requires a specific Flutter version.

I manually edited pubspec.lock.json to update `vector_math`. Without this change, it doesn't compile with the latest Flutter version.
@Luflosi
Copy link
Copy Markdown
Contributor Author

Luflosi commented Feb 19, 2026

Ok, I'm now using flutter341 instead of just flutter.

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Feb 20, 2026
Merged via the queue into NixOS:master with commit 1a42a59 Feb 20, 2026
28 of 31 checks passed
@Luflosi Luflosi deleted the re-add/convertall branch February 20, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants