python3Packages.twisted: skip flaky test on macOS#500926
Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom Apr 11, 2026
Merged
python3Packages.twisted: skip flaky test on macOS#500926SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ange on macOS Reactor timeout caused by a suspected macOS kernel bug where select/kqueue fail to notify that a socket's peer has closed. twisted/twisted#12151
JamieMagee
force-pushed
the
twisted-skip-flaky-macos-test
branch
from
2a6f6e5 to
63c072d
Compare
nixpkgs-ci
Bot
added
10.rebuild-darwin: 501+
Sigmanificient
approved these changes
Mar 26, 2026
nixpkgs-ci
Bot
added
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2935 |
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip
test_fullWriteBufferAfterByteExchangeon macOS. The test hits a reactor timeout after 120 seconds due to what upstream believes is a macOS kernel bug:select/kqueuesometimes fail to wake up when a socket's peer closes. Upstream has been seeing this flake since May 2024 and it's gotten worse on newer Python/macOS combos.twisted/twisted#12151
Also updated the comment on the existing
test_resumeProducingAbort/test_resumeProducingAbortLaterskips to reference the upstream issue instead of pointing at the source file.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.