Conversation
There was a problem hiding this comment.
As previously noted, LGTM!
Suggestion: I did come to think of something, and I apologise for not coming up with it sooner and saving you time. I realised that since sio --version is a valid command, this package could use versionCheckHook as a kind of a smoke test for builds, as in whether they provide a functioning binary in the expected version. Documentation for it is available here and a sample implementation here.
|
Thanks, added version check. For completeness, here's the full log to confirm it worked (btw, it looks like we're running `cargo test` by default)> nix build .#siomon --rebuild -L
siomon> Using versionCheckHook
siomon> Running phase: unpackPhase
siomon> unpacking source archive /nix/store/rwm7qagcq4paz6xwrwy27bbvgl5qzvqd-source
siomon> source root is source
siomon> Executing cargoSetupPostUnpackHook
siomon> Finished cargoSetupPostUnpackHook
siomon> Running phase: patchPhase
siomon> Executing cargoSetupPostPatchHook
siomon> Validating consistency between /build/source/Cargo.lock and /build/siomon-0.2.1-vendor/Cargo.lock
siomon> Finished cargoSetupPostPatchHook
siomon> Running phase: updateAutotoolsGnuConfigScriptsPhase
siomon> Running phase: configurePhase
siomon> Running phase: buildPhase
siomon> Executing cargoBuildHook
siomon> cargoBuildHook flags: -j 32 --target x86_64-unknown-linux-gnu --offline --profile release
siomon> Compiling proc-macro2 v1.0.106
siomon> Compiling quote v1.0.45
siomon> Compiling unicode-ident v1.0.24
siomon> Compiling libc v0.2.182
siomon> Compiling cfg-if v1.0.4
siomon> Compiling version_check v0.9.5
siomon> Compiling typenum v1.19.0
siomon> Compiling serde_core v1.0.228
siomon> Compiling log v0.4.29
siomon> Compiling memchr v2.8.0
siomon> Compiling serde v1.0.228
siomon> Compiling itoa v1.0.17
siomon> Compiling rustversion v1.0.22
siomon> Compiling equivalent v1.0.2
siomon> Compiling zerocopy v0.8.40
siomon> Compiling siphasher v1.0.2
siomon> Compiling rand_core v0.6.4
siomon> Compiling fnv v1.0.7
siomon> Compiling strsim v0.11.1
siomon> Compiling heck v0.5.0
siomon> Compiling signal-hook v0.3.18
siomon> Compiling utf8parse v0.2.2
siomon> Compiling bitflags v2.11.0
siomon> Compiling parking_lot_core v0.9.12
siomon> Compiling ident_case v1.0.1
siomon> Compiling rustix v0.38.44
siomon> Compiling regex-syntax v0.8.10
siomon> Compiling minimal-lexical v0.2.1
siomon> Compiling anstyle-query v1.1.5
siomon> Compiling scopeguard v1.2.0
siomon> Compiling autocfg v1.5.0
siomon> Compiling powerfmt v0.2.0
siomon> Compiling smallvec v1.15.1
siomon> Compiling colorchoice v1.0.4
siomon> Compiling anstyle-parse v0.2.7
siomon> Compiling anstyle v1.0.13
siomon> Compiling is_terminal_polyfill v1.70.2
siomon> Compiling subtle v2.6.1
siomon> Compiling rand v0.8.5
siomon> Compiling lock_api v0.4.14
siomon> Compiling bitflags v1.3.2
siomon> Compiling phf_shared v0.11.3
siomon> Compiling deranged v0.5.8
siomon> Compiling num-conv v0.1.0
siomon> Compiling cpufeatures v0.2.17
siomon> Compiling either v1.15.0
siomon> Compiling ryu v1.0.23
siomon> Compiling cfg_aliases v0.2.1
siomon> Compiling hashbrown v0.16.1
siomon> Compiling foldhash v0.1.5
siomon> Compiling anstream v0.6.21
siomon> Compiling time-core v0.1.7
siomon> Compiling paste v1.0.15
siomon> Compiling instability v0.3.10
siomon> Compiling zmij v1.0.21
siomon> Compiling linux-raw-sys v0.4.15
siomon> Compiling allocator-api2 v0.2.21
siomon> Compiling nix v0.29.0
siomon> Compiling serde_json v1.0.149
siomon> Compiling static_assertions v1.1.0
siomon> Compiling unicode-segmentation v1.12.0
siomon> Compiling generic-array v0.14.7
siomon> Compiling unicode-width v0.1.14
siomon> Compiling nonmax v0.5.5
siomon> Compiling indoc v2.0.7
siomon> Compiling itertools v0.13.0
siomon> Compiling clap_lex v1.0.0
siomon> Compiling thiserror v2.0.18
siomon> Compiling winnow v0.7.15
siomon> Compiling toml_write v0.1.2
siomon> Compiling phf v0.11.3
siomon> Compiling num-traits v0.2.19
siomon> Compiling nom v7.1.3
siomon> Compiling clap_builder v4.5.60
siomon> Compiling cassowary v0.3.0
siomon> Compiling aho-corasick v1.1.4
siomon> Compiling phf_generator v0.11.3
siomon> Compiling csv-core v0.1.13
siomon> Compiling iana-time-zone v0.1.65
siomon> Compiling md5 v0.7.0
siomon> Compiling jiff v0.2.23
siomon> Compiling phf_codegen v0.11.3
siomon> Compiling hashbrown v0.15.5
siomon> Compiling unicode-width v0.2.0
siomon> Compiling raw-cpuid v11.6.0
siomon> Compiling libloading v0.8.9
siomon> Compiling glob v0.3.3
siomon> Compiling indexmap v2.13.0
siomon> Compiling castaway v0.2.4
siomon> Compiling compact_str v0.8.1
siomon> Compiling syn v2.0.117
siomon> Compiling lru v0.12.5
siomon> Compiling time v0.3.45
siomon> Compiling crypto-common v0.1.7
siomon> Compiling block-padding v0.3.3
siomon> Compiling block-buffer v0.10.4
siomon> Compiling inout v0.1.4
siomon> Compiling digest v0.10.7
siomon> Compiling cipher v0.4.4
siomon> Compiling regex-automata v0.4.14
siomon> Compiling hmac v0.12.1
siomon> Compiling sha1 v0.10.6
siomon> Compiling unicode-truncate v1.1.0
siomon> Compiling aes v0.8.4
siomon> Compiling cbc v0.1.2
siomon> Compiling errno v0.3.14
siomon> Compiling getrandom v0.2.17
siomon> Compiling mio v1.1.1
siomon> Compiling nix v0.26.4
siomon> Compiling signal-hook-registry v1.4.8
siomon> Compiling parking_lot v0.12.5
siomon> Compiling pci-ids v0.2.6
siomon> Compiling signal-hook-mio v0.2.5
siomon> Compiling crossterm v0.28.1
siomon> Compiling ipmi-rs-core v0.5.0
siomon> Compiling csv v1.4.0
siomon> Compiling regex v1.12.3
siomon> Compiling ppv-lite86 v0.2.21
siomon> Compiling darling_core v0.20.11
siomon> Compiling env_filter v1.0.0
siomon> Compiling rand_chacha v0.3.1
siomon> Compiling env_logger v0.11.9
siomon> Compiling serde_derive v1.0.228
siomon> Compiling strum_macros v0.26.4
siomon> Compiling thiserror-impl v2.0.18
siomon> Compiling clap_derive v4.5.55
siomon> Compiling ipmi-rs v0.5.0
siomon> Compiling darling_macro v0.20.11
siomon> Compiling strum v0.26.3
siomon> Compiling clap v4.5.60
siomon> Compiling darling v0.20.11
siomon> Compiling ratatui v0.29.0
siomon> Compiling serde_spanned v0.6.9
siomon> Compiling toml_datetime v0.6.11
siomon> Compiling chrono v0.4.44
siomon> Compiling toml_edit v0.22.27
siomon> Compiling toml v0.8.23
siomon> Compiling siomon v0.2.1 (/build/source)
siomon> Finished `release` profile [optimized] target(s) in 30.68s
siomon> Executing cargoInstallPostBuildHook
siomon> Finished cargoInstallPostBuildHook
siomon> Finished cargoBuildHook
siomon> buildPhase completed in 31 seconds
siomon> Running phase: checkPhase
siomon> Executing cargoCheckHook
siomon> cargoCheckHook flags: -j 32 --profile release --target x86_64-unknown-linux-gnu --offline --
siomon> Compiling cfg-if v1.0.4
siomon> Compiling log v0.4.29
siomon> Compiling memchr v2.8.0
siomon> Compiling itoa v1.0.17
siomon> Compiling equivalent v1.0.2
siomon> Compiling libc v0.2.182
siomon> Compiling bitflags v2.11.0
siomon> Compiling utf8parse v0.2.2
siomon> Compiling subtle v2.6.1
siomon> Compiling typenum v1.19.0
siomon> Compiling serde_core v1.0.228
siomon> Compiling zerocopy v0.8.40
siomon> Compiling powerfmt v0.2.0
siomon> Compiling smallvec v1.15.1
siomon> Compiling is_terminal_polyfill v1.70.2
siomon> Compiling regex-syntax v0.8.10
siomon> Compiling colorchoice v1.0.4
siomon> Compiling anstyle-query v1.1.5
siomon> Compiling anstyle v1.0.13
siomon> Compiling scopeguard v1.2.0
siomon> Compiling linux-raw-sys v0.4.15
siomon> Compiling ryu v1.0.23
siomon> Compiling num-conv v0.1.0
siomon> Compiling hashbrown v0.16.1
siomon> Compiling time-core v0.1.7
siomon> Compiling foldhash v0.1.5
siomon> Compiling allocator-api2 v0.2.21
siomon> Compiling bitflags v1.3.2
siomon> Compiling cpufeatures v0.2.17
siomon> Compiling siphasher v1.0.2
siomon> Compiling either v1.15.0
siomon> Compiling castaway v0.2.4
siomon> Compiling winnow v0.7.15
siomon> Compiling anstyle-parse v0.2.7
siomon> Compiling nonmax v0.5.5
siomon> Compiling unicode-width v0.1.14
siomon> Compiling lock_api v0.4.14
siomon> Compiling clap_lex v1.0.0
siomon> Compiling unicode-segmentation v1.12.0
siomon> Compiling strsim v0.11.1
siomon> Compiling toml_write v0.1.2
siomon> Compiling static_assertions v1.1.0
siomon> Compiling strum v0.26.3
siomon> Compiling num-traits v0.2.19
siomon> Compiling deranged v0.5.8
siomon> Compiling phf_shared v0.11.3
siomon> Compiling compact_str v0.8.1
siomon> Compiling zmij v1.0.21
siomon> Compiling cassowary v0.3.0
siomon> Compiling itertools v0.13.0
siomon> Compiling jiff v0.2.23
siomon> Compiling unicode-width v0.2.0
siomon> Compiling iana-time-zone v0.1.65
siomon> Compiling md5 v0.7.0
siomon> Compiling raw-cpuid v11.6.0
siomon> Compiling libloading v0.8.9
siomon> Compiling anstream v0.6.21
siomon> Compiling thiserror v2.0.18
siomon> Compiling rustix v0.38.44
siomon> Compiling glob v0.3.3
siomon> Compiling phf v0.11.3
siomon> Compiling clap_builder v4.5.60
siomon> Compiling pci-ids v0.2.6
siomon> Compiling hashbrown v0.15.5
siomon> Compiling aho-corasick v1.1.4
siomon> Compiling csv-core v0.1.13
siomon> Compiling indexmap v2.13.0
siomon> Compiling generic-array v0.14.7
siomon> Compiling lru v0.12.5
siomon> Compiling crypto-common v0.1.7
siomon> Compiling block-padding v0.3.3
siomon> Compiling block-buffer v0.10.4
siomon> Compiling inout v0.1.4
siomon> Compiling digest v0.10.7
siomon> Compiling time v0.3.45
siomon> Compiling cipher v0.4.4
siomon> Compiling errno v0.3.14
siomon> Compiling getrandom v0.2.17
siomon> Compiling parking_lot_core v0.9.12
siomon> Compiling mio v1.1.1
siomon> Compiling nix v0.26.4
siomon> Compiling nix v0.29.0
siomon> Compiling sha1 v0.10.6
siomon> Compiling hmac v0.12.1
siomon> Compiling signal-hook-registry v1.4.8
siomon> Compiling aes v0.8.4
siomon> Compiling cbc v0.1.2
siomon> Compiling rand_core v0.6.4
siomon> Compiling regex-automata v0.4.14
siomon> Compiling unicode-truncate v1.1.0
siomon> Compiling parking_lot v0.12.5
siomon> Compiling signal-hook v0.3.18
siomon> Compiling signal-hook-mio v0.2.5
siomon> Compiling crossterm v0.28.1
siomon> Compiling serde v1.0.228
siomon> Compiling csv v1.4.0
siomon> Compiling serde_json v1.0.149
siomon> Compiling ipmi-rs-core v0.5.0
siomon> Compiling clap v4.5.60
siomon> Compiling ratatui v0.29.0
siomon> Compiling toml_datetime v0.6.11
siomon> Compiling serde_spanned v0.6.9
siomon> Compiling chrono v0.4.44
siomon> Compiling toml_edit v0.22.27
siomon> Compiling ppv-lite86 v0.2.21
siomon> Compiling rand_chacha v0.3.1
siomon> Compiling regex v1.12.3
siomon> Compiling rand v0.8.5
siomon> Compiling env_filter v1.0.0
siomon> Compiling env_logger v0.11.9
siomon> Compiling ipmi-rs v0.5.0
siomon> Compiling toml v0.8.23
siomon> Compiling siomon v0.2.1 (/build/source)
siomon> Finished `release` profile [optimized] target(s) in 27.13s
siomon> Running unittests src/lib.rs (target/x86_64-unknown-linux-gnu/release/deps/siomon-974e7002411f7c06)
siomon>
siomon> running 207 tests
siomon> test collectors::cpu::tests::test_arm_implementer_name ... ok
siomon> test collectors::cpu::tests::test_parse_arm_cpuinfo_ids_missing_fields ... ok
siomon> test collectors::cpu::tests::test_gather_arm_info_x86_entry ... ok
siomon> test collectors::cpu::tests::test_parse_arm_cpuinfo_ids ... ok
siomon> test collectors::cpu::tests::test_gather_arm_info_arm_entry ... ok
siomon> test collectors::cpu::tests::test_parse_arm_features_none ... ok
siomon> test collectors::cpu::tests::test_parse_hex_or_dec_decimal ... ok
siomon> test collectors::cpu::tests::test_parse_hex_or_dec_hex ... ok
siomon> test collectors::cpu::tests::test_vendor_from_procfs_arm ... ok
siomon> test collectors::cpu::tests::test_parse_hex_or_dec_invalid ... ok
siomon> test collectors::cpu::tests::test_parse_arm_features ... ok
siomon> test collectors::pci::tests::test_parse_bdf ... ok
siomon> test collectors::pci::tests::test_parse_bdf_invalid ... ok
siomon> test collectors::pci::tests::test_parse_bdf_missing_function ... ok
siomon> test collectors::pci::tests::test_parse_bdf_nonzero_function ... ok
siomon> test collectors::pci::tests::test_pcie_speed_to_gen ... ok
siomon> test collectors::pci::tests::test_pcie_speed_to_gen_unknown ... ok
siomon> test config::tests::test_config_path_uses_xdg ... ok
siomon> test config::tests::test_default_config ... ok
siomon> test config::tests::test_parse_minimal_toml ... ok
siomon> test db::boards::tests::test_lookup_asrock_wrx90 ... ok
siomon> test db::boards::tests::test_lookup_asus_wrx90e ... ok
siomon> test config::tests::test_parse_full_toml ... ok
siomon> test db::boards::tests::test_lookup_crosshair_x670e ... ok
siomon> test db::boards::tests::test_lookup_prime_b650 ... ok
siomon> test db::boards::tests::test_lookup_prime_x670e ... ok
siomon> test db::boards::tests::test_lookup_proart_x670e ... ok
siomon> test db::boards::tests::test_lookup_strix_b650e ... ok
siomon> test db::boards::tests::test_lookup_strix_x670e ... ok
siomon> test db::boards::tests::test_lookup_tuf_b650 ... ok
siomon> test db::boards::tests::test_lookup_unknown ... ok
siomon> test db::boards::tests::test_lookup_tuf_x670e ... ok
siomon> test db::boards::tests::test_non_am5_prime_does_not_match ... ok
siomon> test db::boards::tests::test_no_ambiguous_matches ... ok
siomon> test db::boards::tests::test_non_am5_strix_does_not_match ... ok
siomon> test db::boards::tests::test_non_am5_tuf_does_not_match ... ok
siomon> test db::boards::tests::test_resolve_labels_base_plus_override ... ok
siomon> test db::boards::tests::test_wrx90_no_cross_match ... ok
siomon> test db::cpu_codenames::tests::test_amd_zen5_strix_point_mobile ... ok
siomon> test db::boards::tests::test_resolve_labels_no_base ... ok
siomon> test db::cpu_codenames::tests::test_amd_zen2_matisse ... ok
siomon> test db::cpu_codenames::tests::test_amd_zen5_turin_threadripper ... ok
siomon> test db::cpu_codenames::tests::test_arm_returns_none ... ok
siomon> test db::cpu_codenames::tests::test_intel_raptor_lake ... ok
siomon> test db::cpu_codenames::tests::test_amd_zen5_granite_ridge ... ok
siomon> test db::cpu_codenames::tests::test_lookup_arm_ampere_altra ... ok
siomon> test db::cpu_codenames::tests::test_lookup_arm_apple_m1_firestorm ... ok
siomon> test db::cpu_codenames::tests::test_lookup_arm_cortex_a72 ... ok
siomon> test db::cpu_codenames::tests::test_lookup_arm_neoverse_n1 ... ok
siomon> test db::cpu_codenames::tests::test_lookup_arm_unknown ... ok
siomon> test db::cpu_codenames::tests::test_lookup_arm_qualcomm_oryon ... ok
siomon> test db::mce::tests::test_amd_smca_bank_names ... ok
siomon> test db::mce::tests::test_intel_mca_bank_names ... ok
siomon> test db::cpu_codenames::tests::test_unknown_returns_none ... ok
siomon> test db::mce::tests::test_mca_error_codes ... ok
siomon> test db::sensor_labels::tests::test_builtin_labels_asrock_wrx90 ... ok
siomon> test db::sensor_labels::tests::test_builtin_labels_crosshair_x670 ... ok
siomon> test db::sensor_labels::tests::test_builtin_labels_strix_x670e ... ok
siomon> test db::sensor_labels::tests::test_builtin_labels_unknown_board ... ok
siomon> test db::sensor_labels::tests::test_builtin_labels_wrx90e ... ok
siomon> test db::sensor_labels::tests::test_load_labels_no_board ... ok
siomon> test db::sensor_labels::tests::test_builtin_labels_prime_x670e ... ok
siomon> test db::sensor_labels::tests::test_user_labels_override_builtin ... ok
siomon> test db::voltage_scaling::tests::test_lookup_crosshair ... ok
siomon> test db::voltage_scaling::tests::test_default_has_no_multipliers ... ok
siomon> test db::sensor_labels::tests::test_builtin_labels_tuf_b650 ... ok
siomon> test db::voltage_scaling::tests::test_lookup_none ... ok
siomon> test db::voltage_scaling::tests::test_lookup_unknown_board ... ok
siomon> test db::voltage_scaling::tests::test_lookup_wrx90e ... ok
siomon> test db::voltage_scaling::tests::test_voltage_scaling_calculation ... ok
siomon> test model::sensor::tests::test_natural_sort_basic ... ok
siomon> test model::sensor::tests::test_natural_sort_same ... ok
siomon> test model::sensor::tests::test_sensor_reading_new ... ok
siomon> test model::sensor::tests::test_sensor_reading_update ... ok
siomon> test model::sensor::tests::test_sensor_unit_display ... ok
siomon> test model::sensor::tests::test_natural_sort_sequence ... ok
siomon> test output::text::tests::test_format_bytes_bytes ... ok
siomon> test output::text::tests::test_format_bytes_gib ... ok
siomon> test output::text::tests::test_format_bytes_kib ... ok
siomon> test output::text::tests::test_format_bytes_mib ... ok
siomon> test output::tui::dashboard::tests::test_net_bar_exceeds_link_speed ... ok
siomon> test output::text::tests::test_format_bytes_tib ... ok
siomon> test output::tui::dashboard::tests::test_net_bar_full_link_speed ... ok
siomon> test output::tui::dashboard::tests::test_net_bar_half_link_speed ... ok
siomon> test output::tui::dashboard::tests::test_net_bar_log_scale_high ... ok
siomon> test output::tui::dashboard::tests::test_net_bar_log_scale_low ... ok
siomon> test output::tui::dashboard::tests::test_net_bar_zero_traffic ... ok
siomon> test parsers::smbios::tests::test_find_structure_end_no_strings ... ok
siomon> test parsers::smbios::tests::test_find_structure_end_with_strings ... ok
siomon> test parsers::smbios::tests::test_format_uuid ... ok
siomon> test parsers::smbios::tests::test_get_string_basic ... ok
siomon> test parsers::smbios::tests::test_get_string_filters_placeholders ... ok
siomon> test parsers::smbios::tests::test_memory_size_empty ... ok
siomon> test parsers::smbios::tests::test_memory_size_extended ... ok
siomon> test parsers::smbios::tests::test_memory_size_kb_unit ... ok
siomon> test parsers::smbios::tests::test_memory_type_name ... ok
siomon> test parsers::smbios::tests::test_parse_baseboard ... ok
siomon> test parsers::smbios::tests::test_parse_bios ... ok
siomon> test parsers::smbios::tests::test_parse_full_table ... ok
siomon> test parsers::smbios::tests::test_parse_memory_device_basic ... ok
siomon> test parsers::smbios::tests::test_parse_system_uuid ... ok
siomon> test parsers::smbios::tests::test_type_detail_string ... ok
siomon> test platform::procfs::tests::test_parse_cpuinfo_empty ... ok
siomon> test platform::port_io::tests::test_is_available_returns_bool ... ok
siomon> test platform::procfs::tests::test_parse_cpuinfo_no_trailing_newline ... ok
siomon> test platform::procfs::tests::test_parse_cpuinfo_single_processor ... ok
siomon> test platform::procfs::tests::test_parse_cpuinfo_two_processors ... ok
siomon> test platform::procfs::tests::test_parse_meminfo_basic ... ok
siomon> test platform::procfs::tests::test_parse_meminfo_empty ... ok
siomon> test platform::sata_ioctl::tests::test_parse_smart_attribute ... ok
siomon> test platform::sata_ioctl::tests::test_parse_smart_data_page ... ok
siomon> test platform::sata_ioctl::tests::test_sata_smart_to_smart_data ... ok
siomon> test platform::sata_ioctl::tests::test_sg_io_hdr_size ... ok
siomon> test platform::sata_ioctl::tests::test_smart_cdb ... ok
siomon> test platform::sinfo_io::tests::test_hwm_access_open_returns_some_or_none ... ok
siomon> test platform::sinfo_io::tests::test_ioctl_numbers ... ok
siomon> test platform::sinfo_io::tests::test_sinfo_io_availability ... ok
siomon> test platform::sinfo_io::tests::test_struct_sizes ... ok
siomon> test platform::sysfs::tests::cached_file_open_nonexistent ... ok
siomon> test platform::sysfs::tests::cached_file_multiple_reads_same_handle ... ok
siomon> test platform::sysfs::tests::cached_file_non_numeric_returns_none ... ok
siomon> test platform::sysfs::tests::cached_file_read_string_empty_returns_none ... ok
siomon> test platform::sysfs::tests::cached_file_read_u64 ... ok
siomon> test sensors::alerts::tests::test_matches_pattern_exact ... ok
siomon> test platform::sysfs::tests::cached_file_read_raw ... ok
siomon> test platform::sysfs::tests::cached_file_read_string_trims ... ok
siomon> test platform::sysfs::tests::cached_file_read_u64_hex ... ok
siomon> test sensors::alerts::tests::test_alert_engine_triggers ... ok
siomon> test sensors::alerts::tests::test_parse_alert_above ... ok
siomon> test sensors::alerts::tests::test_parse_alert_invalid ... ok
siomon> test sensors::alerts::tests::test_parse_alert_below_with_cooldown ... ok
siomon> test platform::sysfs::tests::cached_file_rereads_after_external_write ... ok
siomon> test sensors::edac::tests::test_edac_sensor_id_format ... ok
siomon> test sensors::edac::tests::test_edac_source_empty_when_no_edac ... ok
siomon> test sensors::hsmp::tests::hsmp_message_size ... ok
siomon> test sensors::hwmon::tests::test_gpu_prefix_label ... ok
siomon> test sensors::hwmon::tests::test_is_gpu_hwmon_chip ... ok
siomon> test sensors::i2c::bus_scan::tests::classify_designware ... ok
siomon> test sensors::hsmp::tests::discover_without_hardware ... ok
siomon> test sensors::i2c::pmbus::tests::discover_returns_empty_without_hardware ... ok
siomon> test sensors::alerts::tests::test_alert_engine_respects_cooldown ... ok
siomon> test sensors::i2c::pmbus::tests::linear11_negative_mantissa ... ok
siomon> test sensors::i2c::pmbus::tests::linear11_pin_5_75w ... ok
siomon> test sensors::i2c::pmbus::tests::linear11_pout_7_1w ... ok
siomon> test sensors::i2c::pmbus::tests::linear11_temp_35c ... ok
siomon> test sensors::i2c::pmbus::tests::linear11_iout_6_6a ... ok
siomon> test sensors::i2c::pmbus::tests::linear16_vout_1_10v ... ok
siomon> test sensors::i2c::pmbus::tests::linear16_vout_mode_0x18 ... ok
siomon> test sensors::i2c::pmbus::tests::linear16_zero ... ok
siomon> test sensors::i2c::pmbus::tests::sign_extend_negative ... ok
siomon> test sensors::i2c::bus_scan::tests::classify_i801 ... ok
siomon> test sensors::i2c::pmbus::tests::sign_extend_positive ... ok
siomon> test sensors::i2c::bus_scan::tests::classify_piix4 ... ok
siomon> test sensors::i2c::smbus_io::tests::ioctl_data_layout_sizes ... ok
siomon> test sensors::i2c::spd5118::tests::discover_returns_empty_without_hardware ... ok
siomon> test sensors::i2c::spd5118::tests::temp_25_0625 ... ok
siomon> test sensors::i2c::smbus_io::tests::open_nonexistent_bus_returns_error ... ok
siomon> test sensors::i2c::bus_scan::tests::classify_other ... ok
siomon> test sensors::i2c::spd5118::tests::temp_25_degrees ... ok
siomon> test sensors::i2c::spd5118::tests::temp_85_degrees ... ok
siomon> test sensors::i2c::spd5118::tests::temp_max_positive ... ok
siomon> test sensors::aer::tests::test_aer_sensor_id_format ... ok
siomon> test sensors::i2c::spd5118::tests::temp_negative_0_0625 ... ok
siomon> test sensors::i2c::spd5118::tests::temp_negative_25 ... ok
siomon> test sensors::aer::tests::test_aer_source_empty ... ok
siomon> test sensors::i2c::pmbus::tests::linear11_vin_11_92v ... ok
siomon> test sensors::i2c::pmbus::tests::linear11_zero ... ok
siomon> test sensors::ipmi::tests::convert_with_b_exponent ... ok
siomon> test sensors::ipmi::tests::convert_with_b_offset ... ok
siomon> test sensors::ipmi::tests::convert_with_exponents ... ok
siomon> test sensors::ipmi::tests::convert_with_multiplier ... ok
siomon> test sensors::ipmi::tests::find_device_path ... ok
siomon> test sensors::ipmi::tests::map_discrete_returns_none ... ok
siomon> test sensors::ipmi::tests::map_fan ... ok
siomon> test sensors::ipmi::tests::map_temperature ... ok
siomon> test sensors::i2c::spd5118::tests::temp_zero ... ok
siomon> test sensors::ipmi::tests::map_voltage ... ok
siomon> test sensors::i2c::bus_scan::tests::classify_nvidia ... ok
siomon> test sensors::mce::tests::test_mce_no_error_sentinel ... ok
siomon> test sensors::mce::tests::test_mce_sensor_id_format ... ok
siomon> test sensors::mce::tests::test_mce_source_empty ... ok
siomon> test sensors::mce::tests::test_mce_status_bits ... ok
siomon> test sensors::alerts::tests::test_matches_pattern_glob ... ok
siomon> test sensors::mce::tests::test_read_mce_status_hex_formats ... ok
siomon> test sensors::superio::chip_detect::tests::test_identify_nuvoton_nct6799 ... ok
siomon> test sensors::superio::chip_detect::tests::test_identify_nuvoton_unknown ... ok
siomon> test sensors::ipmi::tests::convert_simple ... ok
siomon> test sensors::superio::chip_detect::tests::test_kernel_driver_check ... ok
siomon> test sensors::superio::ite87xx::tests::test_fan_reg_count ... ok
siomon> test sensors::superio::chip_detect::tests::test_chip_type_display ... ok
siomon> test sensors::superio::ite87xx::tests::test_fan_rpm ... ok
siomon> test sensors::superio::ite87xx::tests::test_scaled_channel ... ok
siomon> test sensors::superio::chip_detect::tests::test_identify_ite ... ok
siomon> test sensors::i2c::bus_scan::tests::smbus_check ... ok
siomon> test sensors::superio::chip_detect::tests::test_identify_nuvoton_nct6798 ... ok
siomon> test sensors::superio::ite87xx::tests::test_temp_reg_count ... ok
siomon> test sensors::superio::ite87xx::tests::test_voltage_16mv_adc ... ok
siomon> test sensors::superio::ite87xx::tests::test_voltage_12mv_adc ... ok
siomon> test sensors::superio::ite87xx::tests::test_voltage_reg_count ... ok
siomon> test sensors::superio::nct67xx::tests::test_fan_register_addresses ... ok
siomon> test sensors::superio::nct67xx::tests::test_fan_rpm_direct ... ok
siomon> test sensors::superio::nct67xx::tests::test_fan_rpm_zero ... ok
siomon> test sensors::superio::nct67xx::tests::test_voltage_calculation_no_multiplier ... ok
siomon> test sensors::superio::nct67xx::tests::test_temp_source_labels ... ok
siomon> test sensors::superio::nct67xx::tests::test_voltage_calculation_with_multiplier ... ok
siomon> test sensors::superio::nct67xx::tests::test_voltage_regs_count ... ok
siomon> test sensors::superio::nct67xx::tests::test_voltage_scale_array_length ... ok
siomon>
siomon> test result: ok. 207 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
siomon>
siomon> Running unittests src/main.rs (target/x86_64-unknown-linux-gnu/release/deps/sio-c941d79f56763807)
siomon>
siomon> running 0 tests
siomon>
siomon> test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
siomon>
siomon> Running tests/integration.rs (target/x86_64-unknown-linux-gnu/release/deps/integration-238de0578b7821bc)
siomon>
siomon> running 19 tests
siomon> test test_cli_default_format_is_text ... ok
siomon> test test_cli_monitor_mode ... ok
siomon> test test_cli_explicit_format_overrides_config ... ok
siomon> test test_cli_flag_precedence_with_subcommand ... ok
siomon> test test_cli_config_applied_when_no_explicit_flag ... ok
siomon> test test_sensor_reading_update_tracks_min_max ... ok
siomon> test test_sensor_id_natural_sort ... ok
siomon> test test_sata_smart_temperature_mapping ... ok
siomon> test test_config_roundtrip_toml ... ok
siomon> test test_cli_no_flag_uses_config ... ok
siomon> test test_sensor_id_display_format ... ok
siomon> test test_label_loading_no_board_user_only ... ok
siomon> test test_storage_interface_serialization ... ok
siomon> test test_label_loading_with_config_override ... ok
siomon> test test_voltage_scaling_default_no_multipliers ... ok
siomon> test test_voltage_scaling_lookup_strix ... ok
siomon> test test_cli_subcommand_parsing ... ok
siomon> test test_system_info_json_roundtrip ... ok
siomon> test test_cli_options_after_subcommand_works ... ok
siomon>
siomon> test result: ok. 19 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
siomon>
siomon> Doc-tests siomon
siomon>
siomon> running 0 tests
siomon>
siomon> test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
siomon>
siomon> Finished cargoCheckHook
siomon> Running phase: installPhase
siomon> Executing cargoInstallHook
siomon> Finished cargoInstallHook
siomon> Running phase: fixupPhase
siomon> shrinking RPATHs of ELF executables and libraries in /nix/store/vf7qibdrmfazwwhg7a3cgqdw3w29imfz-siomon-0.2.1
siomon> shrinking /nix/store/vf7qibdrmfazwwhg7a3cgqdw3w29imfz-siomon-0.2.1/bin/sio
siomon> checking for references to /build/ in /nix/store/vf7qibdrmfazwwhg7a3cgqdw3w29imfz-siomon-0.2.1...
siomon> patching script interpreter paths in /nix/store/vf7qibdrmfazwwhg7a3cgqdw3w29imfz-siomon-0.2.1
siomon> stripping (with command strip and flags -S -p) in /nix/store/vf7qibdrmfazwwhg7a3cgqdw3w29imfz-siomon-0.2.1/bin
siomon> Running phase: installCheckPhase
siomon> Executing versionCheckPhase
siomon> Successfully managed to find version 0.2.1 in the output of the command /nix/store/vf7qibdrmfazwwhg7a3cgqdw3w29imfz-siomon-0.2.1/bin/sio --version
siomon> sio 0.2.1
siomon> Finished versionCheckPhase
siomon> no Makefile or custom installCheckPhase, doing nothing |
hekazu
left a comment
There was a problem hiding this comment.
No further comments, approved!
|
@hekazu Shall I add EDIT: I would appreciate if you could re-approve after those changes |
|
nice. it worked. I also updated from > nix-shell maintainers/scripts/update.nix --argstr package siomon
this derivation will be built:
/nix/store/g5csi90d25saq3pbsjm90z7h3mrdgvk7-packages.json.drv
building '/nix/store/g5csi90d25saq3pbsjm90z7h3mrdgvk7-packages.json.drv'...
Going to be running update for following packages:
- siomon-0.2.1
Press Enter key to continue...
Running update for:
Enqueuing group of 1 packages
- siomon-0.2.1: UPDATING ...
- siomon-0.2.1: DONE.
Packages updated! |
|
I have not utilised To note, as far as I understand from nixpkgs-update's maintainer FAQ adding |
|
Thanks. I tried locally without |
|
@hekazu do you know what needs to happen now for this to be merged? |
Someone with commit access needs to merge it. See this section of CONTRIBUTING.md for further suggestions on making it happen. |
|
@markuskowa you merged my PRs before ( |
level1techs#34 NixOS/nixpkgs#501034 Co-authored-by: vinylen <victor@viclab.me> Co-authored-by: sheevy <mw.kubica@gmail.com>
level1techs#34 NixOS/nixpkgs#501034 Co-authored-by: vinylen <victor@viclab.me> Co-authored-by: sheevy <mw.kubica@gmail.com>
This PR is the same as #499549 but the PR request comes from a branch in my
nixpkgsfork.New linux monitoring tool from Level1Tech.
Post announcing it: https://forum.level1techs.com/t/first-linux-weekly-stream-5-30pm-est/247201
Repo: https://github.com/level1techs/siomon
Crate (which I don't use): https://crates.io/crates/siomon
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.