parted: 3.6 -> 3.7#509452
Merged
r-vdp merged 2 commits intoNixOS:masterfrom Apr 14, 2026
Merged
Conversation
nixpkgs-ci
Bot
added
8.has: package (update)
Hythera
reviewed
Apr 13, 2026
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
Hythera
approved these changes
Apr 13, 2026
Member
Hythera
left a comment
Hythera
left a comment
There was a problem hiding this comment.
LGTM 👍
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 509452
Commit: 76dd8e314aa2d828be88a1dea9e209c2c2a0d76d
x86_64-linux
⏩ 7 packages marked as broken and skipped:
- CuboCore.corestuff
- haskellPackages.batchd-libvirt
- haskellPackages.batchd-libvirt.doc
- haskellPackages.libvirt-hs
- haskellPackages.libvirt-hs.doc
- htcondor
- xmonad_log_applet
✅ 262 packages built:
- CuboCore.coreaction
- CuboCore.corearchiver
- CuboCore.corefm
- CuboCore.coregarage
- CuboCore.corehunt
- CuboCore.coreimage
- CuboCore.coreinfo
- CuboCore.corekeyboard
- CuboCore.corepad
- CuboCore.corepaint
- CuboCore.corepdf
- CuboCore.corepins
- CuboCore.corerenamer
- CuboCore.coreshot
- CuboCore.corestats
- CuboCore.coreterminal
- CuboCore.coretime
- CuboCore.coretoppings
- CuboCore.coreuniverse
- CuboCore.libcsys
- adapta-gtk-theme
- almanah
- appvm
- astal.mpris
- ayatana-indicator-datetime
- blivet-gui
- blivet-gui.dist
- bubblemail
- bubblemail.dist
- budgie-control-center
- budgie-control-center.debug
- calamares
- calamares-nixos
- calamares-nixos.debug
- calamares.debug
- calls
- calls.devdoc
- cantata
- ceph
- ceph-client (ceph-client.client, ceph-client.dev, ceph-client.doc, ceph-client.lib, ceph-client.man, ceph.client)
- ceph-csi
- ceph.dev
- ceph.doc
- libceph (ceph.lib, libceph.client, libceph.dev, libceph.doc, libceph.lib, libceph.man)
- ceph.man
- cheese
- cheese.devdoc
- cheese.man
- cinnamon
- cinnamon-gsettings-overrides
- cinnamon-screensaver
- clementine
- collectd
- diffoscope
- diffoscope.dist
- diffoscope.man
- endeavour
- enlightenment.enlightenment
- eos-installer
- evolution
- evolution-data-server
- evolution-data-server-gtk4
- evolution-data-server-gtk4.dev
- evolution-data-server.dev
- evolution-ews
- evolution.man
- evolutionWithPlugins
- exaile
- f3
- fatresize
- fdroidserver
- fdroidserver.dist
- field-monitor
- folks
- folks.dev
- folks.devdoc
- geary
- gitg
- gnome-applets
- gnome-boxes
- gnome-browser-connector
- gnome-calendar
- gnome-contacts
- gnome-control-center
- gnome-control-center.debug
- gnome-disk-utility
- gnome-flashback
- gnome-multi-writer
- gnome-music
- gnome-notes
- gnome-online-accounts
- gnome-online-accounts-gtk
- gnome-online-accounts.debug
- gnome-online-accounts.dev
- gnome-online-accounts.devdoc
- gnome-online-accounts.man
- gnome-panel
- gnome-panel-with-modules
- gnome-panel.dev
- gnome-panel.man
- gnome-photos
- gnome-photos.installedTests
- gnome-session
- gnome-session.debug
- gnome-session.sessions
- gnome-shell
- gnome-shell.debug
- gnome-shell.devdoc
- gnome-tweaks
- gnome.gvfs
- gnome.gvfs.debug
- gnome.nixos-gsettings-overrides
- gnomeExtensions.easyScreenCast
- gnomeExtensions.gsconnect
- gnomeExtensions.gsconnect.installedTests
- gparted
- gparted-full
- grilo-plugins
- guestfs-tools
- guymager
- gvfs
- gvfs.debug
- hardinfo2
- hyprpanel
- kdePackages.kpmcore
- kdePackages.kpmcore.debug
- kdePackages.kpmcore.dev
- kdePackages.kpmcore.devtools
- kdePackages.partitionmanager
- kdePackages.partitionmanager.debug
- kdePackages.partitionmanager.dev
- kdePackages.partitionmanager.devtools
- libblockdev
- libblockdev.dev
- libblockdev.devdoc
- libblockdev.python
- libguestfs (python313Packages.guestfs)
- libguestfs-with-appliance
- libguestfs-with-appliance.guestfsd
- libguestfs.guestfsd (python313Packages.guestfs.guestfsd)
- libmsgraph
- libmsgraph.dev
- libmsgraph.devdoc
- librenms
- libvirt
- libvirt-dbus
- libvirt-dbus.man
- libvirt-glib
- libvirt-glib.dev
- libvirt-glib.devdoc
- libvmi
- libvmi.dev
- libvmi.lib
- lomiri.lomiri-music-app
- lomiri.mediascanner2
- lomiri.mediascanner2.dev
- marble-shell-theme
- mate-control-center
- mate-panel-with-applets
- mate-panel-with-applets.man
- mate-settings-daemon-wrapped
- mate-settings-daemon-wrapped.man
- mate-utils
- mate-utils.man
- matrix-gtk-theme
- mediawriter
- mgmt
- minikube
- mojave-gtk-theme
- nemo
- nemo-fileroller
- nemo-preview
- nemo-python
- nemo-seahorse
- nemo-with-extensions
- nemo.dev
- nemo.man
- nixpkgs-manual
- ns-usbloader
- nwipe
- ocamlPackages.ocaml_libvirt
- pantheon.elementary-calendar
- pantheon.elementary-greeter
- pantheon.elementary-gsettings-schemas
- pantheon.elementary-mail
- pantheon.elementary-monitor
- pantheon.elementary-session-settings
- pantheon.elementary-tasks
- pantheon.switchboard-plug-about
- pantheon.switchboard-plug-onlineaccounts
- pantheon.switchboard-with-plugs
- pantheon.wingpanel-applications-menu
- pantheon.wingpanel-indicator-datetime
- pantheon.wingpanel-with-indicators
- parted
- parted.dev
- parted.info
- parted.man
- perl5Packages.SysVirt
- perl5Packages.SysVirt.devdoc
- phosh
- phosh-mobile-settings
- planify
- plasticity
- podman-bootc
- prometheus-libvirt-exporter
- python313Packages.blivet
- python313Packages.blivet.dist
- python313Packages.libvirt
- python313Packages.libvirt.dist
- python313Packages.pyparted
- python313Packages.pyparted.dist
- python314Packages.blivet
- python314Packages.blivet.dist
- python314Packages.guestfs
- python314Packages.guestfs.guestfsd
- python314Packages.libvirt
- python314Packages.libvirt.dist
- python314Packages.pyparted
- python314Packages.pyparted.dist
- qemu_full
- qemu_full.debug
- qemu_full.doc
- qemu_full.ga
- rapid-photo-downloader
- rapid-photo-downloader.dist
- rapidraw
- rubyPackages.ruby-libvirt
- rubyPackages_3_3.ruby-libvirt
- rubyPackages_4_0.ruby-libvirt
- samba4Full
- samba4Full.dev
- samba4Full.man
- solo5
- solo5.debug
- swaynotificationcenter
- swaysettings
- themechanger
- tokyonight-gtk-theme
- totem
- tparted
- udiskie
- udiskie.dist
- udisks
- udisks.dev
- udisks.devdoc
- udisks.man
- usbimager
- usermount
- vagrant
- valent
- vifm-full
- vimix-gtk-themes
- virt-manager
- virt-top
- virt-v2v
- virt-viewer
- virtnbdbackup
- virtnbdbackup.dist
- woeusb
- woeusb-ng
- woeusb-ng.dist
nixpkgs-ci
Bot
added
the
12.approvals: 1
Hythera
reviewed
Apr 13, 2026
Hythera
approved these changes
Apr 13, 2026
Yarny0
approved these changes
Apr 13, 2026
Contributor
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Thanks for assuming maintainership of this package, @kybe236 !
Review per https://github.com/NixOS/nixpkgs/tree/4c1018dae018162ec878d42fec712642d214fdfa/pkgs#package-updates
Everything below built/tested on x86_64-linux, after rebasing the branch onto current nixos-unstable.
Reviewed points
- package name fits guidelines
- package version fits guidelines
- package builds on
x86_64-linux - executables tested on
x86_64-linux - any change of upstream are verified (none)
- the motives for any special packaging choices are documented (not severe, but see below)
- all depending packages build (too many)
- patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed (none)
- patches that are remotely available are fetched rather than vendored (none)
More:
- license still matches upstream
- command line tools (not tested)
- created/modified lots of partitions with
pyparted(this isn'tparted, butpartedis a dependency ofpyparted, so that suggests that thepartedfunctionality still works) -
nixosTests.installer.{swraid,lvm,simpleUefiSystemdBoot}build/pass (they usepartedto create/modify partitions)
Possible improvements
Why is pkg-config added? I suggest to document that in the commit message (but for me, can also be merged without this).
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2943 |
nixpkgs-ci
Bot
added
12.approvals: 2
Member
Author
I’m unsure why exactly builds only started failing due to pkg-config missing in this version. It should be because of this line (503), but that didn’t change in the update. It definitely fails without it, though. |
Contributor
Umm, in that case, I would just document that in the commit message (but again, this is certainly a non-blocking suggestion only). |
Comment on lines
43
to
44
| ++ lib.optional (gettext != null) gettext | ||
| ++ lib.optional (lvm2 != null) lvm2; |
Member
There was a problem hiding this comment.
fyi: overwriting packages with null is kinda an anti pattern which should be faced out. I think here we can just entirely drop thos conditions.
Member
Author
There was a problem hiding this comment.
thanks for the info, gonna make a pr later fixing this here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: https://savannah.gnu.org/news/?id=10879
Diff: https://cgit.git.savannah.gnu.org/cgit/parted.git/diff/?id=v3.7&id2=v3.6
Closes: #482726 (already in upstream)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.