Conversation
e17f4bd to
4b6816a
Compare
|
Builds and runs fine for me. Did some test browsing with it. It's tempting to try to merge the code for the two Brave packages to reduce update work, but probably better to look into that after Origin has had time to stabilize. |
|
Also works for me |
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi @uskudnik, @rht, @JeffLabonte, @nasirhm, @buckley310, Brave Origin is a new, "separate" browser from Brave (https://support.brave.app/hc/en-us/articles/38561489788173-What-is-Brave-Origin). It is currently published through the
The derivation here closely mirrors |
This comment was marked as outdated.
This comment was marked as outdated.
4b6816a to
cfc3092
Compare
|
Thanks for the input @Bad3r! :) I think I have addressed all your comments. Just let me know if I missed something or you have additional feedback. |
|
There was a problem hiding this comment.
Thanks for the input @Bad3r! :)
I think I have addressed all your comments. Just let me know if I missed something or you have additional feedback.
Great, thank you! LGTM, feel free to resolve the inline comments, I can't seem to be able to do it from my end.
Flake lock file updates:
• Updated input 'nixpkgs-patch-brawe-origin':
'NixOS/nixpkgs#511131'
→ 'NixOS/nixpkgs#511131'
|
Started using Brave Origin a couple of days ago, and so far it’s been great. The only thing I noticed is that it’s missing some features from Brave. For example, it does not seem to include the Tor feature. Brave Nightly also lets you choose more specifically what to keep, so I opened PR #513143 to add all the brave channels. While working on it, I also unified everything under a shared |
|
Thanks for the broader work in #513143 :) Could maintainers clarify the preferred path here? My understanding is that this PR is narrower in scope and may be easier to review and merge first, while #513143 takes a broader approach that could be layered on afterward. @buckley310 mentioned it might be smart to wait until Origin has stabilized before merging everything together, which also seems reasonable.
Just a small heads up: I would not necessarily treat that as a drawback for Origin. Brave’s own docs say that its “Private Window with Tor” is not equivalent to Tor Browser, and recommend Tor Browser where anonymity or safety is the goal. So objectively there is not much use of Tor in Brave if even the developer recommends another product.
My understanding is that this is related to Brave Origin’s more configurable upgrade-mode behavior, and that it will reach stable channels soon. |
Adds
brave-originunderpkgs/by-name/br/brave-origin, closely mirroring the existingbravepackage structure.This includes a local
update.sh, a generatedpackage.nix, and support for the upstream-confirmed release artifacts available for1.91.71.I copied most of the files from the already packaged
brave. If any of the maintainers of that (@uskudnik @rht @JeffLabonte @nasirhm @buckley310 ) have any improvements, want to be added as maintainers too, or have any other plans please tell me.Things done
nix-build lib/tests/maintainers.nix./result-brave-origin/bin/brave-origin --versionNotes
Supported platforms are limited to the upstream artifacts currently published for this release:
x86_64-linuxaarch64-darwinx86_64-darwinaarch64-linuxwas not added because no matching upstream install artifact was available.