Skip to content

brave-origin: init at 1.91.109#511131

Open
WitteShadovv wants to merge 2 commits intoNixOS:masterfrom
WitteShadovv:brave-origin
Open

brave-origin: init at 1.91.109#511131
WitteShadovv wants to merge 2 commits intoNixOS:masterfrom
WitteShadovv:brave-origin

Conversation

@WitteShadovv
Copy link
Copy Markdown

Adds brave-origin under pkgs/by-name/br/brave-origin, closely mirroring the existing brave package structure.
This includes a local update.sh, a generated package.nix, and support for the upstream-confirmed release artifacts available for 1.91.71.

I copied most of the files from the already packaged brave. If any of the maintainers of that (@uskudnik @rht @JeffLabonte @nasirhm @buckley310 ) have any improvements, want to be added as maintainers too, or have any other plans please tell me.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Ran the maintainer check: nix-build lib/tests/maintainers.nix
  • Ran formatting
  • Tested the main executable:
    • ./result-brave-origin/bin/brave-origin --version
  • Added maintainer in a separate earlier commit

Notes

Supported platforms are limited to the upstream artifacts currently published for this release:

  • x86_64-linux
  • aarch64-darwin
  • x86_64-darwin
    aarch64-linux was not added because no matching upstream install artifact was available.

@nixpkgs-ci nixpkgs-ci Bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 18, 2026
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Apr 18, 2026
@buckley310
Copy link
Copy Markdown
Contributor

Builds and runs fine for me. Did some test browsing with it.

It's tempting to try to merge the code for the two Brave packages to reduce update work, but probably better to look into that after Origin has had time to stabilize.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Apr 18, 2026
@themarcel
Copy link
Copy Markdown

Also works for me

Comment thread pkgs/by-name/br/brave-origin/make-brave.nix Outdated
Comment thread pkgs/by-name/br/brave-origin/make-brave.nix Outdated
Comment thread pkgs/by-name/br/brave-origin/make-brave.nix Outdated
Comment thread pkgs/by-name/br/brave-origin/update.sh Outdated
@Bad3r

This comment was marked as outdated.

@Bad3r
Copy link
Copy Markdown
Contributor

Bad3r commented Apr 23, 2026

Hi @uskudnik, @rht, @JeffLabonte, @nasirhm, @buckley310,
as the maintainers of the existing brave package, your input on this PR would be very welcome.

Brave Origin is a new, "separate" browser from Brave (https://support.brave.app/hc/en-us/articles/38561489788173-What-is-Brave-Origin). It is currently published through the -nightly pre-release track.

What is Brave Origin?

Brave Origin is a paid* version of the browser for users who don’t need all the features that support Brave as a business, but still want the privacy that only Brave offers. Origin users will continue to benefit from our industry-leading privacy, adblock, and speed (via Shields), as well as regular software updates, Chromium patches, and security and privacy improvements. Origin will remove** most other features from the browser.

* Origin is available as a free download for Linux desktop users.

** If you opt to use Origin as an upgrade to the existing version of Brave on your device, you’ll unlock a new Settings panel where you can toggle features on / off as you wish.

The derivation here closely mirrors pkgs/by-name/br/brave/, so it might be better to factor both brave packages into a single channel-parameterised make-brave.nix shared across brave and brave-origin.

Comment thread pkgs/by-name/br/brave-origin/update.sh Outdated
@Bad3r

This comment was marked as outdated.

@WitteShadovv WitteShadovv changed the title brave-origin: init at 1.91.71 brave-origin: init at 1.91.109 Apr 24, 2026
@WitteShadovv
Copy link
Copy Markdown
Author

Thanks for the input @Bad3r! :)

I think I have addressed all your comments. Just let me know if I missed something or you have additional feedback.

@Bad3r
Copy link
Copy Markdown
Contributor

Bad3r commented Apr 24, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 511131
Commit: cfc309238360a9f5e5e7612b87df8083fb69ef09 (subsequent changes)
Merge: 58f84e81a3a7a021282468216a2059c7e55ea259

Logs: https://github.com/Bad3r/nixpkgs-review-gha/actions/runs/24879185112


x86_64-linux

✅ 1 package built:
  • brave-origin

aarch64-linux

No rebuilds


x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • brave-origin

aarch64-darwin

No rebuilds

Copy link
Copy Markdown
Contributor

@Bad3r Bad3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input @Bad3r! :)

I think I have addressed all your comments. Just let me know if I missed something or you have additional feedback.

Great, thank you! LGTM, feel free to resolve the inline comments, I can't seem to be able to do it from my end.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 24, 2026
ymstnt added a commit to ymstnt/dotfiles that referenced this pull request Apr 24, 2026
Flake lock file updates:

• Updated input 'nixpkgs-patch-brawe-origin':
    'NixOS/nixpkgs#511131'
  → 'NixOS/nixpkgs#511131'
@Dreaming-Codes
Copy link
Copy Markdown

Started using Brave Origin a couple of days ago, and so far it’s been great. The only thing I noticed is that it’s missing some features from Brave. For example, it does not seem to include the Tor feature.

Brave Nightly also lets you choose more specifically what to keep, so I opened PR #513143 to add all the brave channels. While working on it, I also unified everything under a shared make-brave.nix, which supersedes this PR.

@WitteShadovv
Copy link
Copy Markdown
Author

Thanks for the broader work in #513143 :)

Could maintainers clarify the preferred path here? My understanding is that this PR is narrower in scope and may be easier to review and merge first, while #513143 takes a broader approach that could be layered on afterward. @buckley310 mentioned it might be smart to wait until Origin has stabilized before merging everything together, which also seems reasonable.

For example, it does not seem to include the Tor feature.

Just a small heads up: I would not necessarily treat that as a drawback for Origin. Brave’s own docs say that its “Private Window with Tor” is not equivalent to Tor Browser, and recommend Tor Browser where anonymity or safety is the goal. So objectively there is not much use of Tor in Brave if even the developer recommends another product.

Brave Nightly also lets you choose more specifically what to keep

My understanding is that this is related to Brave Origin’s more configurable upgrade-mode behavior, and that it will reach stable channels soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants