Skip to content

Use mousetrap.js minified version#5012

Merged
julianlam merged 1 commit into
NodeBB:masterfrom
phit:patch-1
Sep 6, 2016
Merged

Use mousetrap.js minified version#5012
julianlam merged 1 commit into
NodeBB:masterfrom
phit:patch-1

Conversation

@phit
Copy link
Copy Markdown

@phit phit commented Sep 4, 2016

didn't see a reason it shouldn't use the minified version

didn't see a reason it shouldn't use the minified version
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 4, 2016

CLA assistant check
All committers have signed the CLA.

@julianlam julianlam merged commit 4410385 into NodeBB:master Sep 6, 2016
@julianlam
Copy link
Copy Markdown
Member

Makes sense 😄

We don't require the minified version because it's requested over the wire after the main payload is delivered, but as you say, there's no reason we shouldn't require the minified version.

@julianlam julianlam self-assigned this Sep 6, 2016
@julianlam julianlam added this to the 1.2.0 milestone Sep 6, 2016
@phit phit deleted the patch-1 branch September 15, 2016 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants