Skip to content

Privileges for Admin Control Panel#8355

Merged
julianlam merged 22 commits into
masterfrom
acp-privileges-redux
Jun 5, 2020
Merged

Privileges for Admin Control Panel#8355
julianlam merged 22 commits into
masterfrom
acp-privileges-redux

Conversation

@julianlam
Copy link
Copy Markdown
Member

@julianlam julianlam commented Jun 1, 2020

  • Introduces the admin privilege set, which joins the category privilege and global privilege sets
  • Fixes a bug where giving or rescinding global privileges didn't fire the correct hook (breaking change)
  • New hooks: action:privileges.admin.give, action:privileges.admin.rescind, fired when hooks are granted and rescinded, respectively.

I will append changes to the PR description as they are made.

@julianlam julianlam added this to the 1.14.0 milestone Jun 1, 2020
@julianlam julianlam self-assigned this Jun 1, 2020
@julianlam
Copy link
Copy Markdown
Member Author

julianlam commented Jun 1, 2020

Breaking Changes

  • When global privileges are granted, the action:privileges.global.give and action:privileges.global.rescind hooks are now fired. Prior to this change, action:privileges.categories.give and action:privileges.categories.rescind were incorrectly fired with cid 0 -- no cids are passed in the global variants of the hook
  • If a theme overrides ACP pages, some templates (namely, partials/menu.tpl, partials/quick_actions/buttons.tpl, and admin/dashboard.tpl) will need updating

@julianlam julianlam force-pushed the acp-privileges-redux branch from 74b4d8c to 4edff9a Compare June 4, 2020 20:01
@julianlam julianlam marked this pull request as ready for review June 5, 2020 18:49
@julianlam julianlam merged commit a82e9bd into master Jun 5, 2020
@julianlam julianlam deleted the acp-privileges-redux branch June 5, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant