Update vendored JShrink to v1.8.1 (fixes regex character-class minification)#3130
Merged
xirvik merged 1 commit intoJul 24, 2026
Merged
Conversation
…cation) The bundled JShrink minifier's saveRegex() treated the first unescaped '/' as the end of a regex literal, but a '/' inside a character class ([...]) is a literal slash. So a pattern like /[^/]/ was cut mid-regex and the rest of the file mangled, producing an "unterminated regular expression literal" SyntaxError in the browser. getplugins.php minifies the entire concatenated plugin bundle in a single pass, so one such regex in any plugin breaks the whole minified bundle and leaves the UI unable to load (empty torrent list). Several bundled plugins use class-internal slashes, e.g. /themes\/([^/]+)\// and the [^:/?#] announce-URL parser. JShrink v1.8.1 tracks the character class and only ends the regex on a '/' outside a class. It is namespaced (JShrink\Minifier), so getplugins.php now references \JShrink\Minifier::minify(); the class autoloader already strips namespaces, so nothing else needs to change. Adds tests/php/MinifierTest.php locking in the character-class behaviour and guarding plain regexes and division operators from being mis-parsed.
xirvik
force-pushed
the
fix/jshrink-v1.8.1-regex-character-class
branch
from
July 24, 2026 05:28
2e22808 to
d5a0ce2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled JShrink minifier's saveRegex() treated the first unescaped '/' as the end of a regex literal, but a '/' inside a character class ([...]) is a literal slash. So a pattern like /[^/]/ was cut mid-regex and the rest of the file mangled, producing an "unterminated regular expression literal" SyntaxError in the browser.
getplugins.php minifies the entire concatenated plugin bundle in a single pass, so one such regex in any plugin breaks the whole minified bundle and leaves the UI unable to load (empty torrent list). Several bundled plugins use class-internal slashes, e.g. /themes/([^/]+)// and the [^:/?#] announce-URL parser.
JShrink v1.8.1 tracks the character class and only ends the regex on a '/' outside a class. It is namespaced (JShrink\Minifier), so getplugins.php now references \JShrink\Minifier::minify(); the class autoloader already strips namespaces, so nothing else needs to change.
Adds tests/php/MinifierTest.php locking in the character-class behaviour and guarding plain regexes and division operators from being mis-parsed.