CI: run the PHP test suite (and make it gate)#3131
Merged
Conversation
The PHP tests under tests/ were never executed in CI -- only the Jest (JS) suite ran. Wire the PHP suite in and make it fail the build on failures: - tests.yml: add a `php` job (setup-php 8.1) that runs tests/php-test.sh. - php-test.sh: exit non-zero when any test file reports a failure. Two signals are honoured -- a non-zero process exit (the TestLib self-running suites end with exit($failures)) and failure output (the TestCase runner only prints Passed/Failed). Previously the script never gated, so failures were invisible to CI. - PermissionTest::testPermission hardcoded uid 1000, so it only passed when the tests happened to run as uid 1000 -- never true in CI (uid 1001) or on most machines. Probe with the running process's own uid/gids instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP tests under tests/ were never executed in CI -- only the Jest (JS) suite ran. Wire the PHP suite in and make it fail the build on failures:
phpjob (setup-php 8.1) that runs tests/php-test.sh.