feat(webui): make HTTP/HTTPS URLs clickable in Tracker Status - #3141
Merged
Conversation
…with XSS sanitization and unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables automatic conversion of
http://andhttps://URLs in the Tracker status field (under the "General" torrent details tab) into safe, clickable links that open in a new tab.Key Changes
Helper Function (
getClickableTrackerStatus):getClickableTrackerStatus(text)injs/common.js.escapeHTML()(escaping&,<,>,",') before parsing links.http://andhttps://links embedded in text (e.g.,"New torrent at https://tracker.example.com/torrent.php?id=123. Please update.")..,), and,punctuation from the hyperlink tag so they remain as normal trailing text.target="_blank"andrel="noopener noreferrer".WebUI Details Tab:
#tselement rendering injs/webui.jsto usegetClickableTrackerStatus(d.msg).Automated Tests:
tests/js/trackerstatus.spec.jstesting link generation, text surrounding URLs, trailing punctuation stripping, XSS sanitization, and protocol filtering.Verification
Run Jest test suite: