Fix Oblivion scrollbars in Firefox 153 - #3153
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3152
Firefox 153 recognizes
::-webkit-scrollbarwhile reporting no support for::-webkit-scrollbar-thumb. This can apply the custom scrollbar dimensions without the corresponding thumb styling, causing the scrollbar thumb to disappear.This patch guards only the scrollbar geometry rule with
@supports selector(::-webkit-scrollbar-thumb). The existing thumb, button, track-piece, and corner rules are unchanged.Validated with Firefox 153 on Windows 10 against three ruTorrent instances using Oblivion, and with OblivionBlue on one instance. Chrome 151.0.7922.76 on Windows 10 was used as a regression check.