erasedata: delete the data of downloads rtorrent has not opened - #3154
Merged
Conversation
d.base_path and f.frozen_path are filled in when rtorrent opens a download's file list, and are not restored from the session. A download that has not been opened since rtorrent started therefore reports both as empty -- which is every torrent that was stopped when the session was loaded. removewithdata collected no paths for those, skipped writing the <hash>.list that the garbage collector consumes, and erased the torrent anyway, leaving the data on disk with nothing left to identify it. Both "Delete Data" and "Delete Path" were affected, because the list is skipped before the delete mode is read. Starting the torrent or forcing a recheck opens the file list and makes the next attempt succeed, which is why this looks like "old torrents do not delete their data". Fall back to d.directory and f.path, which are always available, and keep the torrent when neither source resolves rather than erasing a download whose files can no longer be identified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d.base_path and f.frozen_path are filled in when rtorrent opens a download's file list, and are not restored from the session. A download that has not been opened since rtorrent started therefore reports both as empty -- which is every torrent that was stopped when the session was loaded.
removewithdata collected no paths for those, skipped writing the .list that the garbage collector consumes, and erased the torrent anyway, leaving the data on disk with nothing left to identify it. Both "Delete Data" and "Delete Path" were affected, because the list is skipped before the delete mode is read. Starting the torrent or forcing a recheck opens the file list and makes the next attempt succeed, which is why this looks like "old torrents do not delete their data".
Fall back to d.directory and f.path, which are always available, and keep the torrent when neither source resolves rather than erasing a download whose files can no longer be identified.