lint: use the config filename editorconfig-checker 5 actually reads - #3164
Merged
Conversation
.github/workflows/lint.yml runs npx editorconfig-checker@5, and v5 reads .editorconfig-checker.json; .ecrc is the deprecated name. The repo's Exclude list (minified assets, vendored libraries, tests fixtures) was therefore ignored, so the advisory job warned about the filename and reported findings the project has explicitly excluded. Pure rename, content byte-identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
Taking this — the deprecation warning is real and renaming ahead of the removal is worth doing. The description overstates it though. npx --yes editorconfig-checker@5 installs checker v3.11.1, which still reads .ecrc and applies it; it only warns. Checked here: with .ecrc in place the run is 0 findings (including a trailing-whitespace line I added to an excluded file to be sure the Exclude list was live), and it only starts reporting excluded paths once .ecrc is moved away. So the exclusions were being honoured, and the before/after in "How to verify" differs only by the warning line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem.
.github/workflows/lint.ymlrunsnpx editorconfig-checker@5, and v5reads
.editorconfig-checker.json;.ecrcis the deprecated v2 name. The repo'sExclude list (minified assets, vendored jquery/bootstrap/codemirror, test fixtures)
is therefore ignored: the job warns about the filename and reports findings the
project explicitly excluded.
Fix.
git mv .ecrc .editorconfig-checker.json— content byte-identical.How to verify. Before:
npx --yes editorconfig-checker@5from the repo rootprints the deprecated-filename warning and flags vendored files. After: exclusions
honoured, warning gone.