Check that ruTorrent has registered its handlers with rtorrent - #3182
Merged
Conversation
env_check.php now asks rtorrent which keys are set on event.download.inserted_new. Everything there except rtorrent own 1_prepare and ~_save_full was installed by ruTorrent from a plugin init.php on a page load, and rtorrent never persists them. After rtorrent restarts with nobody opening the web UI there are none, and torrents added by any other client silently get no ratio group, no added time and no history entry. Warns rather than fails, since an install with those plugins disabled is legitimate, and points at php/initplugins.php.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
env_check.php now asks rtorrent which keys are set on event.download.inserted_new. Everything there except rtorrent own 1_prepare and ~_save_full was installed by ruTorrent from a plugin init.php on a page load, and rtorrent never persists them. After rtorrent restarts with nobody opening the web UI there are none, and torrents added by any other client silently get no ratio group, no added time and no history entry.
Warns rather than fails, since an install with those plugins disabled is legitimate, and points at php/initplugins.php.