Skip to content

[MIG][15.0] mail: migration script#3273

Merged
pedrobaeza merged 1 commit intoOCA:15.0from
sang250399:v15_mig_mail
Jul 6, 2022
Merged

[MIG][15.0] mail: migration script#3273
pedrobaeza merged 1 commit intoOCA:15.0from
sang250399:v15_mig_mail

Conversation

@sang250399
Copy link

This PR

Migration done

@StefanRijnhart
Copy link
Member

Thanks for the quick fixes! This is really great work especially for you as a new contributor.

I see that due to a small error in our scripting the mail module is not upgraded in this PRs github action. I'm hoping to have it fixed in #3278. Would you like to try and merge that branch in here?

@sang250399
Copy link
Author

Thanks for the quick fixes! This is really great work especially for you as a new contributor.

I see that due to a small error in our scripting the mail module is not upgraded in this PRs github action. I'm hoping to have it fixed in #3278. Would you like to try and merge that branch in here?

okay, i will try

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, scripts are now run!

Testing modules base,base,mail
...
2022-06-14 09:47:58,233 5347 INFO openupgrade odoo.modules.migration: module mail: Running migration [>15.0.1.5] pre-migration 
...
2022-06-14 09:48:00,643 5347 INFO openupgrade odoo.modules.migration: module mail: Running migration [15.0.1.5>] post-migration

@legalsylvain

This comment was marked as duplicate.

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 15, 2022
@legalsylvain
Copy link
Contributor

/ocabot migration mail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect syntax

Suggested change
| mail |Done | |
| mail | Done | |

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment is pending, and also on the test logs, there is the following line:

2022-06-15 06:18:28,759 5443 INFO openupgrade odoo.modules.graph: module mail: Unmet dependencies: base_setup, bus, web_tour 

so this is not correct and can't be merged. Please check it.

@royle-vietnam
Copy link
Contributor

My comment is pending, and also on the test logs, there is the following line:

Done

2022-06-15 06:18:28,759 5443 INFO openupgrade odoo.modules.graph: module mail: Unmet dependencies: base_setup, bus, web_tour

Maybe the docsource file is not standard, |Nothing to do -> | Nothing to do, Can you do mass editing PR? @pedrobaeza

@pedrobaeza
Copy link
Member

Yes, that syntax is not correct and it's not correctly parsed. Please fix it in the rest of your PRs. I'll fix the current main one.

@pedrobaeza
Copy link
Member

Are you the one that have put No DB layout changes in the docs? That's not a valid text. It should be Nothing to do.

@royle-vietnam
Copy link
Contributor

Yes, that syntax is not correct and it's not correctly parsed. Please fix it in the rest of your PRs. I'll fix the current main one.

Okey

@royle-vietnam
Copy link
Contributor

Are you the one that have put No DB layout changes in the docs? That's not a valid text. It should be Nothing to do.

No, not me, looks like @legalsylvain

@legalsylvain
Copy link
Contributor

Are you the one that have put No DB layout changes in the docs? That's not a valid text. It should be Nothing to do.

Hum.... @pedrobaeza :
OCA/server-tools#2206 (comment)

@pedrobaeza
Copy link
Member

I didn't remember that this text is parsed by the tests:

| grep "Done\|Partial\|Nothing" \

so this has to be changed.

@pedrobaeza
Copy link
Member

Sorry for the noise. @legalsylvain it was correct, as such column is an extra one. Digging more about why base_setup is not being considered.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, as now I have re-run the tests and they are working, so let's continue. I'm worried about these situations being masked on the CI and only searching for the green status. I will continue checking the logs of other PRs to see if this happens again.

@pedrobaeza pedrobaeza merged commit 977d1bc into OCA:15.0 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants